Date: Tue, 17 Nov 2015 09:15:49 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Laura Abbott <laura@labbott.name>
Cc: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Andrew Andrianov <andrew@ncrmnt.org>, arve@android.com,
        Riley Andrews <riandrews@android.com>, devel@driverdev.osuosl.org,
        devicetree@vger.kernel.org, Feng Tang <feng.tang@intel.com>,
        Tom Gall <tom.gall@linaro.org>, romlem@google.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Colin Cross <ccross@google.com>,
        John Stultz <john.stultz@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        linux-arm-kernel@lists.infradead.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCHv2 2/3] staging: ion: Add files for parsing the devicetree
Message-ID: <20151117061549.GM18797@mwanda>
References: <1447721855-7574-1-git-send-email-laura@labbott.name>
 <1447721855-7574-3-git-send-email-laura@labbott.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447721855-7574-3-git-send-email-laura@labbott.name>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 932
Lines: 32

On Mon, Nov 16, 2015 at 04:57:34PM -0800, Laura Abbott wrote:
> +	for_each_available_child_of_node(dt_node, node) {
> +		struct platform_device *heap_pdev;
> +
> +		ret = ion_parse_dt_heap_common(node, &heaps[i], compatible);
> +		if (ret)
> +			return ERR_PTR(ret);
> +
> +		heap_pdev = of_platform_device_create(node, heaps[i].name,
> +							&pdev->dev);

We should free these if something fails later in the function.

> +		if (!pdev)
> +			return ERR_PTR(-ENOMEM);
> +		heap_pdev->dev.platform_data = &heaps[i];
> +
> +		heaps[i].priv = &heap_pdev->dev;
> +
> +		ret = ion_setup_heap_common(pdev, node, &heaps[i]);
> +		if (ret)
> +			return ERR_PTR(ret);


regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/