Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694AbbKQIaA (ORCPT ); Tue, 17 Nov 2015 03:30:00 -0500 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:5847 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbbKQI37 (ORCPT ); Tue, 17 Nov 2015 03:29:59 -0500 X-RM-TRANSID: 2ee1564ae5805ee-7d0d7 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee4564ae57e5e5-fbf4d Date: Tue, 17 Nov 2015 16:29:42 +0800 From: Yaowei Bai To: David Rientjes Cc: akpm@linux-foundation.org, bhe@redhat.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, dave@stgolabs.net, dhowells@redhat.com, dingel@linux.vnet.ibm.com, hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de, mhocko@suse.cz, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, penberg@kernel.org, sasha.levin@oracle.com, tj@kernel.org, tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool Message-ID: <20151117082942.GA8832@yaowei-K42JY> References: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447656686-4851-7-git-send-email-baiyaowei@cmss.chinamobile.com> <20151117015950.GA5867@yaowei-K42JY> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2300 Lines: 67 On Mon, Nov 16, 2015 at 09:44:11PM -0800, David Rientjes wrote: > On Tue, 17 Nov 2015, Yaowei Bai wrote: > > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index 6523109..14a6249 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -378,9 +378,9 @@ static inline enum zone_type gfp_zone(gfp_t flags) > > static inline int gfp_zonelist(gfp_t flags) > > { > > if (IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE)) > > - return 1; > > + return ZONELIST_NOFALLBACK; > > > > - return 0; > > + return ZONELIST_FALLBACK; > > } > > > > /* > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > > index e23a9e7..9664d6c 100644 > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -576,8 +576,6 @@ static inline bool zone_is_empty(struct zone *zone) > > /* Maximum number of zones on a zonelist */ > > #define MAX_ZONES_PER_ZONELIST (MAX_NUMNODES * MAX_NR_ZONES) > > > > -#ifdef CONFIG_NUMA > > - > > /* > > * The NUMA zonelists are doubled because we need zonelists that restrict the > > * allocations to a single node for __GFP_THISNODE. > > @@ -585,10 +583,13 @@ static inline bool zone_is_empty(struct zone *zone) > > * [0] : Zonelist with fallback > > * [1] : No fallback (__GFP_THISNODE) > > */ > > -#define MAX_ZONELISTS 2 > > -#else > > -#define MAX_ZONELISTS 1 > > +enum { > > + ZONELIST_FALLBACK, > > +#ifdef CONFIG_NUMA > > + ZONELIST_NOFALLBACK, > > #endif > > + MAX_ZONELISTS > > +}; > > > > /* > > * This struct contains information about a zone in a zonelist. It is stored > > This is a different change than the original. The original patch doesn't make sense as you said so let's drop it. > I don't see a benefit from > it, but I have no strong feelings on it. If someone else finds value in > this, please update the comment when defining the enum as well. OK, i'll send a update patch to review first and if nobody disagrees with it i will resend this patchset. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/