Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753657AbbKQJ4R (ORCPT ); Tue, 17 Nov 2015 04:56:17 -0500 Received: from mail-ig0-f169.google.com ([209.85.213.169]:34499 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753520AbbKQJ4L (ORCPT ); Tue, 17 Nov 2015 04:56:11 -0500 MIME-Version: 1.0 In-Reply-To: <564A5DC8.9090307@redhat.com> References: <1447359670-23652-1-git-send-email-labbott@fedoraproject.org> <564A5DC8.9090307@redhat.com> Date: Tue, 17 Nov 2015 10:56:10 +0100 Message-ID: Subject: Re: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro From: Ard Biesheuvel To: Laura Abbott Cc: Laura Abbott , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1291 Lines: 42 On 16 November 2015 at 23:50, Laura Abbott wrote: > On 11/14/2015 11:38 PM, Ard Biesheuvel wrote: >> >> On 12 November 2015 at 21:21, Laura Abbott >> wrote: >>> >>> The permissions in mark_rodata_ro trigger a build error >>> with STRICT_MM_TYPECHECKS. Fix this by introducing >>> PAGE_KERNEL_ROX for the same reasons as PAGE_KERNEL_RO. >> >> >> Forgive the bikeshedding but perhaps PAGE_KERNEL_EXEC_RO is more >> consistent? >> > > powerpc was using PAGE_KERNEL_ROX so I went with that. Blame powerpc ;) > OK, in that case, let's keep PAGE_KERNEL_ROX >>> >>> From Ard: >>> >>> "PAGE_KERNEL_EXEC has PTE_WRITE set as well, making the range >>> writeable under the ARMv8.1 DBM feature, that manages the >>> dirty bit in hardware (writing to a page with the PTE_RDONLY >>> and PTE_WRITE bits both set will clear the PTE_RDONLY bit in that case)" >>> >>> Signed-off-by: Laura Abbott >> >> >> Acked-by: Ard Biesheuvel >> > > Thanks, > Laura > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/