Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753380AbbKQKCt (ORCPT ); Tue, 17 Nov 2015 05:02:49 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:34909 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbbKQKCq (ORCPT ); Tue, 17 Nov 2015 05:02:46 -0500 Date: Tue, 17 Nov 2015 11:02:42 +0100 From: Daniel Vetter To: Alexandre Courbot Cc: Thierry Reding , Terje Bergstrom , linux-tegra@vger.kernel.org, gnurou@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/tegra: fix locking of SET_TILING ioctl Message-ID: <20151117100241.GN16848@phenom.ffwll.local> Mail-Followup-To: Alexandre Courbot , Thierry Reding , Terje Bergstrom , linux-tegra@vger.kernel.org, gnurou@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1447312196-11470-1-git-send-email-acourbot@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447312196-11470-1-git-send-email-acourbot@nvidia.com> X-Operating-System: Linux phenom 4.1.0-2-amd64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1845 Lines: 56 On Thu, Nov 12, 2015 at 04:09:56PM +0900, Alexandre Courbot wrote: > drm_gem_object_unreference() now expects obj->dev->struct_mutex to be > held. Use the newly-introduced drm_gem_object_unreference_unlocked() > which handles locking for us. This rule has been really old, I simply made the checking more anal in commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 Author: Daniel Vetter Date: Thu Oct 15 09:36:25 2015 +0200 drm/gem: Check locking in drm_gem_object_unreference With the above added this is: Reviewed-by: Daniel Vetter > > If we don't do this drm_gem_object_unreference() will get noisy about > struct_mutex not being held every time we call the SET_TILING ioctl. > > Signed-off-by: Alexandre Courbot > --- > drivers/gpu/drm/tegra/drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c > index cc48334ef164..c0ae89865958 100644 > --- a/drivers/gpu/drm/tegra/drm.c > +++ b/drivers/gpu/drm/tegra/drm.c > @@ -683,7 +683,7 @@ static int tegra_gem_set_tiling(struct drm_device *drm, void *data, > bo->tiling.mode = mode; > bo->tiling.value = value; > > - drm_gem_object_unreference(gem); > + drm_gem_object_unreference_unlocked(gem); > > return 0; > } > -- > 2.6.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/