Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbbKQKEW (ORCPT ); Tue, 17 Nov 2015 05:04:22 -0500 Received: from mail-ob0-f196.google.com ([209.85.214.196]:36607 "EHLO mail-ob0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbbKQKES (ORCPT ); Tue, 17 Nov 2015 05:04:18 -0500 MIME-Version: 1.0 In-Reply-To: References: <1446583017-19021-1-git-send-email-jarod@redhat.com> <1446610172-21420-1-git-send-email-jarod@redhat.com> <20151104.215632.964832400121049446.davem@davemloft.net> <56452E2A.9050501@gmail.com> Date: Tue, 17 Nov 2015 11:04:17 +0100 X-Google-Sender-Auth: qhu7qlGyRyY7vMQDcYHtxHy0BLo Message-ID: Subject: Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs From: Geert Uytterhoeven To: Florian Fainelli Cc: David Miller , Jarod Wilson , "linux-kernel@vger.kernel.org" , Eric Dumazet , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Nikolay Aleksandrov , Michal Kubecek , Alexander Duyck , "netdev@vger.kernel.org" , Andrew Lunn , Vivien Didelot , Linux-sh list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 41 On Tue, Nov 17, 2015 at 10:02 AM, Geert Uytterhoeven wrote: > On Fri, Nov 13, 2015 at 1:26 AM, Florian Fainelli wrote: >> On 04/11/15 18:56, David Miller wrote: >>>> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") >>> ... >>>> Reported-by: Nikolay Aleksandrov >>>> Signed-off-by: Jarod Wilson >>>> --- >>>> v2: Based on suggestions from Alex, and with not changing err to ret, this >>>> patch actually becomes quite minimal and doesn't ugly up the code much. >>> >>> Applied, thanks. >> >> This causes some warnings to be displayed for DSA stacked devices: > > And a few more: > > sh-eth ee700000.ethernet eth0: set_features() failed (-1); wanted > 0x0000000000004000, left 0x0000000000004800 > g_ether gadget usb0: set_features() failed (-1); wanted > 0x0000000000004000, left 0x0000000000004800 smsc911x 8000000.ethernet eth0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/