Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbbKQLXs (ORCPT ); Tue, 17 Nov 2015 06:23:48 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:41011 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbbKQLXr (ORCPT ); Tue, 17 Nov 2015 06:23:47 -0500 Date: Tue, 17 Nov 2015 12:23:43 +0100 From: Peter Zijlstra To: Vineet Gupta Cc: Noam Camus , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, talz@ezchip.com, gilf@ezchip.com, cmetcalf@ezchip.com Subject: Re: [PATCH v2 18/19] ARC: [plat-eznps] replace sync with proper cpu barrier Message-ID: <20151117112343.GW3816@twins.programming.kicks-ass.net> References: <1446297327-16298-1-git-send-email-noamc@ezchip.com> <1446893557-29748-19-git-send-email-noamc@ezchip.com> <564B0BB1.8080709@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564B0BB1.8080709@synopsys.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 20 On Tue, Nov 17, 2015 at 04:42:49PM +0530, Vineet Gupta wrote: > On Saturday 07 November 2015 04:22 PM, Noam Camus wrote: > > From: Tal Zilcer > > > > In SMT system like we have the generic "sync" is not working with > > HW threads. The replacement is "schd.rw" instruction that is served > > as cpu barrier for HW threads. > > As discussed in v2 of this patch, SYNC or some such in __switch_to is completely > superfluous. We don't need this patch, you may instead wanna submit a patch which > removes the sync. Also please do that in assembler version of this file as well ! Do test it though; as is ARC-SMP seems to have a _lot_ of superfluous barriers many of which have no explanation yet (I'm thinking of those extra smp_mb()s in the lock primitives). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/