Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752884AbbKQMW4 (ORCPT ); Tue, 17 Nov 2015 07:22:56 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:33878 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705AbbKQMWy (ORCPT ); Tue, 17 Nov 2015 07:22:54 -0500 Subject: Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init To: Marc Gonzalez , Thomas Gleixner References: <1447412292-841-1-git-send-email-daniel.lezcano@linaro.org> <5645D5A0.1000502@sigmadesigns.com> Cc: LKML , Linux ARM , Arnd Bergmann From: Daniel Lezcano Message-ID: <564B1C1C.7070801@linaro.org> Date: Tue, 17 Nov 2015 13:22:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5645D5A0.1000502@sigmadesigns.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1189 Lines: 36 On 11/13/2015 01:20 PM, Marc Gonzalez wrote: > On 13/11/2015 11:58, Daniel Lezcano wrote: > >> The current code to initialize, register and read the clocksource is >> already factored out in mmio.c via the clocksource_mmio_init function. >> >> Factor out the code with the clocksource_mmio_init function. > > The reason I didn't like clocksource_mmio_init() is because it exports > 4 generic accessors. > > I guess this function makes more sense when all platforms are using it, > in an ARCH_MULTIPLATFORM kernel. (Also the accessors are probably quite > small, so the waste is probably minimal.) Hi Marc, it is not clear for me if you agree with this patch or not. Can you clarify ? Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/