Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbbKQMdq (ORCPT ); Tue, 17 Nov 2015 07:33:46 -0500 Received: from mail.kernel.org ([198.145.29.136]:45806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbbKQMdo (ORCPT ); Tue, 17 Nov 2015 07:33:44 -0500 Date: Tue, 17 Nov 2015 09:33:40 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: masami.hiramatsu.pt@hitachi.com, ast@kernel.org, lizefan@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org, He Kuang , Namhyung Kim Subject: Re: [PATCH] perf record: Support custom vmlinux path Message-ID: <20151117123340.GG22729@kernel.org> References: <20151117012924.GA22729@kernel.org> <1447753484-176754-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447753484-176754-1-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2098 Lines: 59 Em Tue, Nov 17, 2015 at 09:44:44AM +0000, Wang Nan escreveu: > From: He Kuang > > Make perf-record command support --vmlinux option if BPF_PROLOGUE is on. > > 'perf record' needs vmlinux as the source of DWARF info to generate > prologue for BPF programs, so path of vmlinux should be specified. > > Short name 'k' has been taken by 'clockid'. This patch skips the short > option name and use '--vmlinux' for vmlinux path. > > Signed-off-by: He Kuang > Signed-off-by: Wang Nan > Cc: Alexei Starovoitov > Cc: Arnaldo Carvalho de Melo > Cc: Masami Hiramatsu > Cc: Namhyung Kim > Cc: Zefan Li > Cc: pi3orama@163.com > --- > > Hi Arnaldo, > > This patch is a standalone improvement to support BPF argument fetching > better. Without this patch vmlinux must be reside in standard path > for BPF loader finding it. I think you can review this patch with other > patch I send today. Other patch on my local tree is not belong to this > topic. Thanks, applying. > Thank you. > > --- > tools/perf/builtin-record.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 199fc31..cfd0e14 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -1118,6 +1118,10 @@ struct option __record_options[] = { > "clang binary to use for compiling BPF scriptlets"), > OPT_STRING(0, "clang-opt", &llvm_param.clang_opt, "clang options", > "options passed to clang when compiling BPF scriptlets"), > +#ifdef HAVE_BPF_PROLOGUE > + OPT_STRING(0, "vmlinux", &symbol_conf.vmlinux_name, > + "file", "vmlinux pathname"), > +#endif > #endif > OPT_END() > }; > -- > 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/