Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752873AbbKQMm3 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Nov 2015 07:42:29 -0500
Received: from mail.kernel.org ([198.145.29.136]:46306 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751262AbbKQMm2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Nov 2015 07:42:28 -0500
Date: Tue, 17 Nov 2015 09:42:24 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: He Kuang <hekuang@huawei.com>, Wang Nan <wangnan0@huawei.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Alexei Starovoitov <ast@kernel.org>, lizefan@huawei.com,
        pi3orama@163.com, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf record: Support custom vmlinux path
Message-ID: <20151117124224.GH22729@kernel.org>
References: <20151117012924.GA22729@kernel.org>
 <1447753484-176754-1-git-send-email-wangnan0@huawei.com>
 <20151117123340.GG22729@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151117123340.GG22729@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1374
Lines: 40

Em Tue, Nov 17, 2015 at 09:33:40AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 17, 2015 at 09:44:44AM +0000, Wang Nan escreveu:
> 
> Thanks, applying.

I take that back, I think this is questionable, we should instead always
have the --vmlinux option, and when the feature it deals with is not
built in, warn the user about it, something like:

  #  perf record --vmlinux /a/b/c ...
  WARNING: --vmlinux being ignored, as BPF prologue not built-in...
  <output that can be produced while ignoring --vmlinux>

And please consider that for other options that are surrounded by ifdefs
related to the eBPF support, there are a few more, clang related.

Also this isn't updating the perf-record man page, please do so and
please put this in a separate section for BPF related options, something
like:

--------------------

BPF:

These options can be used when BPF support is built-in.

...

---------------------

This way the user gets to know that the tool can be used with BPF while
reading its documentation and if they decide to try it, then the
warnings will be presented if the feature is not built-in.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/