Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753466AbbKQMpp (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Nov 2015 07:45:45 -0500
Received: from m12-17.163.com ([220.181.12.17]:59535 "EHLO m12-17.163.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753345AbbKQMpn convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Nov 2015 07:45:43 -0500
Content-Type: text/plain;
	charset=gb2312
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] perf record: Support custom vmlinux path
From: pi3orama <pi3orama@163.com>
X-Mailer: iPhone Mail (13B143)
In-Reply-To: <20151117124224.GH22729@kernel.org>
Date: Tue, 17 Nov 2015 20:45:28 +0800
Cc: He Kuang <hekuang@huawei.com>, Wang Nan <wangnan0@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Alexei Starovoitov <ast@kernel.org>, lizefan@huawei.com,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <D3A20266-35B3-4183-93CE-2981E73C4A4A@163.com>
References: <20151117012924.GA22729@kernel.org> <1447753484-176754-1-git-send-email-wangnan0@huawei.com> <20151117123340.GG22729@kernel.org> <20151117124224.GH22729@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
X-CM-TRANSID: EcCowAB3nx9pIUtWMTeeAg--.53909S2
X-Coremail-Antispam: 1Uf129KBjvJXoW7tFyfuFWrJr1xGr1UtF1rCrg_yoW8Jw1fpr
	sxGrsFyF1DGrnFkrn2qF1rZr4IkFs3GF47Jr98AryxAa45uFyI93WfKFWftrWDZ34rtF1I
	vry5Xwn8ZFyY9a7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2
	9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jUManUUUUU=
X-Originating-IP: [210.73.4.168]
X-CM-SenderInfo: lslt02xdpdqiywtou0bp/xtbBzRa1QFO-xE9zCAABsz
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1598
Lines: 50



?????ҵ? iPhone

> ?? 2015??11??17?գ?????8:42??Arnaldo Carvalho de Melo <acme@kernel.org> д????
> 
> Em Tue, Nov 17, 2015 at 09:33:40AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Tue, Nov 17, 2015 at 09:44:44AM +0000, Wang Nan escreveu:
>> 
>> Thanks, applying.
> 
> I take that back, I think this is questionable, we should instead always
> have the --vmlinux option, and when the feature it deals with is not
> built in, warn the user about it, something like:
> 
>  #  perf record --vmlinux /a/b/c ...
>  WARNING: --vmlinux being ignored, as BPF prologue not built-in...
>  <output that can be produced while ignoring --vmlinux>
> 
> And please consider that for other options that are surrounded by ifdefs
> related to the eBPF support, there are a few more, clang related.
> 
> Also this isn't updating the perf-record man page, please do so and
> please put this in a separate section for BPF related options, something
> like:
> 
> --------------------
> 
> BPF:
> 
> These options can be used when BPF support is built-in.
> 
> ...
> 
> ---------------------
> 
> This way the user gets to know that the tool can be used with BPF while
> reading its documentation and if they decide to try it, then the
> warnings will be presented if the feature is not built-in.
> 

Ok. Thanks for your comment. I will do that tomorrow.

> - Arnaldo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/