Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753191AbbKQNCB (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Nov 2015 08:02:01 -0500
Received: from m12-18.163.com ([220.181.12.18]:46018 "EHLO m12-18.163.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751705AbbKQNCA convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Nov 2015 08:02:00 -0500
Content-Type: text/plain;
	charset=gb2312
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 1/5] perf test: Fix 2 bugs in 'perf test BPF'
From: pi3orama <pi3orama@163.com>
X-Mailer: iPhone Mail (13B143)
In-Reply-To: <20151117125644.GI22729@kernel.org>
Date: Tue, 17 Nov 2015 21:01:41 +0800
Cc: Wang Nan <wangnan0@huawei.com>, masami.hiramatsu.pt@hitachi.com,
        ast@kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <674A3364-6B12-406F-B9CE-F4928C293366@163.com>
References: <20151117012924.GA22729@kernel.org> <1447749170-175898-1-git-send-email-wangnan0@huawei.com> <1447749170-175898-2-git-send-email-wangnan0@huawei.com> <20151117125644.GI22729@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
X-CM-TRANSID: EsCowEA5gIY0JUtW5z7nEA--.5222S2
X-Coremail-Antispam: 1Uf129KBjvJXoWxGr48XF1UtFWUGFW7JFy7ZFb_yoW5GFWDpr
	ZxCF4aka4FvF4qv347tFW0gFy2vryxXrWYv3Z3Krs5ArWqyF97K3WxKFyxuFyY934Y9a4x
	Zw4jgrZIk3WDA3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2
	9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U3kuxUUUUU=
X-Originating-IP: [210.73.4.168]
X-CM-SenderInfo: lslt02xdpdqiywtou0bp/xtbBzRa1QFO-xE+sAQAAsk
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3413
Lines: 98



?????ҵ? iPhone

> ?? 2015??11??17?գ?????8:56??Arnaldo Carvalho de Melo <acme@kernel.org> д????
> 
> Em Tue, Nov 17, 2015 at 08:32:46AM +0000, Wang Nan escreveu:
>> Two bugs in 'perf test BPF' are found when testing BPF prologue without
>> vmlinux:
>> 
>> # mv /lib/modules/4.3.0-rc4+/build/vmlinux{,.bak}
>> # ./perf test BPF
>> 37: Test BPF filter                                          :Failed to find the path for kernel: No such file or directory
>> Ok
>> 
>> Test BPF should fail in this case.
>> 
>> This patch fixes two bugs in 'perf test BPF'. After this patch:
>> 
>> # ./perf test BPF
>> 37: Test BPF filter                                          :Failed to find the path for kernel: No such file or directory
>>  FAILED!
>> # mv /lib/modules/4.3.0-rc4+/build/vmlinux{.bak,}
>> # ./perf test BPF
>> 37: Test BPF filter                                          : Ok
> 
> Applied, it is a clear improvement, but:
> 
> [root@zoo ~]# perf test
> 1: vmlinux symtab matches kallsyms                          : Skip
> 2: detect openat syscall event                              : Ok
> <SNIP>
> 5: parse events tests                                       : Ok
> 6: Validate PERF_RECORD_* events & perf_sample fields       : FAILED!
> 7: Test perf pmu format parsing                             : Ok
> <SNIP>
> 37: Test BPF filter                                          :Failed to find the path for kernel: Invalid ELF file
> FAILED!
> 38: x86 rdpmc test                                           : Ok
> 39: Test converting perf time to TSC                         : FAILED!
> 40: Test dwarf unwind                                        : Ok
> 41: Test x86 instruction decoder - new instructions          : Ok
> 42: Test intel cqm nmi context read                          : Skip
> [root@zoo ~]# 
> 
> ------------------------
> 
> It is now the only test to emit some message in non-verbose mode that is not
> "Ok", "FAILED!" or "Skip" :-)
> 

Please see 5/5. In that patch I try to fix it throughly by output redirection.

Thank you.


> - Arnaldo
> 
>> Signed-off-by: Wang Nan <wangnan0@huawei.com>
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> ---
>> tools/perf/tests/bpf.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>> 
>> diff --git a/tools/perf/tests/bpf.c b/tools/perf/tests/bpf.c
>> index c7131fa..dca3998 100644
>> --- a/tools/perf/tests/bpf.c
>> +++ b/tools/perf/tests/bpf.c
>> @@ -102,8 +102,7 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
>>    err = parse_events_load_bpf_obj(&parse_evlist, &parse_evlist.list, obj);
>>    if (err || list_empty(&parse_evlist.list)) {
>>        pr_debug("Failed to add events selected by BPF\n");
>> -        if (!err)
>> -            return TEST_FAIL;
>> +        return TEST_FAIL;
>>    }
>> 
>>    snprintf(pid, sizeof(pid), "%d", getpid());
>> @@ -157,8 +156,10 @@ static int do_test(struct bpf_object *obj, int (*func)(void),
>>        }
>>    }
>> 
>> -    if (count != expect)
>> +    if (count != expect) {
>>        pr_debug("BPF filter result incorrect\n");
>> +        goto out_delete_evlist;
>> +    }
>> 
>>    ret = TEST_OK;
>> 
>> -- 
>> 1.8.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/