Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752476AbbKQNLg (ORCPT ); Tue, 17 Nov 2015 08:11:36 -0500 Received: from mail-ig0-f176.google.com ([209.85.213.176]:37844 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbbKQNLe (ORCPT ); Tue, 17 Nov 2015 08:11:34 -0500 MIME-Version: 1.0 In-Reply-To: References: <201511172007.DmGhbpj1%fengguang.wu@intel.com> Date: Tue, 17 Nov 2015 18:41:34 +0530 Message-ID: Subject: Re: [PATCH v2] usb: chipidea: removing of_find_property From: Saurabh Sengar To: Julia Lawall Cc: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= , Peter.Chen@freescale.com, Greg KH , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3239 Lines: 69 Hi Julia, You have used v2 of patch, I have sent v3 of patch too. 1:30 hour before Please use version 3 as that is the latest. version 3 : https://lkml.org/lkml/2015/11/17/243 Sorry for trouble. Regards, Saurabh On 17 November 2015 at 18:28, Julia Lawall wrote: > Please check. The code, with the blank line on line 692, looks strange. > > julia > > On Tue, 17 Nov 2015, kbuild test robot wrote: > >> CC: kbuild-all@01.org >> In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.truth@gmail.com> >> TO: Saurabh Sengar >> CC: mans@mansr.com, Peter.Chen@freescale.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Saurabh Sengar >> CC: Saurabh Sengar >> >> Hi Saurabh, >> >> [auto build test WARNING on peter.chen-usb/ci-for-usb-next] >> [also build test WARNING on v4.4-rc1 next-20151117] >> >> url: https://github.com/0day-ci/linux/commits/Saurabh-Sengar/usb-chipidea-removing-of_find_property/20151117-194333 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb ci-for-usb-next >> :::::: branch date: 68 minutes ago >> :::::: commit date: 68 minutes ago >> >> >> drivers/usb/chipidea/core.c:693:1-27: code aligned with following code on line 695 >> >> git remote add linux-review https://github.com/0day-ci/linux >> git remote update linux-review >> git checkout 4375ac1189e900bbde912d31ec3bb66572c0784a >> vim +693 drivers/usb/chipidea/core.c >> >> 63863b98 Heikki Krogerus 2015-09-21 687 if (usb_get_maximum_speed(dev) == USB_SPEED_FULL) >> 4f6743d5 Michael Grzeschik 2014-02-19 688 platdata->flags |= CI_HDRC_FORCE_FULLSPEED; >> 4f6743d5 Michael Grzeschik 2014-02-19 689 >> 4375ac11 Saurabh Sengar 2015-11-17 690 if (!of_property_read_u32(dev->of_node, "phy-clkgate-delay-us", >> 4375ac11 Saurabh Sengar 2015-11-17 691 &platdata->phy_clkgate_delay_us)) >> 1fbf4628 Fabio Estevam 2015-09-08 692 >> df96ed8d Peter Chen 2014-09-22 @693 platdata->itc_setting = 1; >> 4375ac11 Saurabh Sengar 2015-11-17 694 >> df96ed8d Peter Chen 2014-09-22 @695 ret = of_property_read_u32(dev->of_node, "itc-setting", >> df96ed8d Peter Chen 2014-09-22 696 &platdata->itc_setting); >> 4375ac11 Saurabh Sengar 2015-11-17 697 if (ret && ret != -EINVAL) { >> 4375ac11 Saurabh Sengar 2015-11-17 698 dev_err(dev, "failed to get itc-setting\n"); >> >> :::::: The code at line 693 was first introduced by commit >> :::::: df96ed8dced21426c54c7f69cf7513e75280957a usb: chipidea: introduce ITC tuning interface >> >> :::::: TO: Peter Chen >> :::::: CC: Peter Chen >> >> --- >> 0-DAY kernel test infrastructure Open Source Technology Center >> https://lists.01.org/pipermail/kbuild-all Intel Corporation >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/