Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753594AbbKQNNN (ORCPT ); Tue, 17 Nov 2015 08:13:13 -0500 Received: from mail-ob0-f175.google.com ([209.85.214.175]:34521 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbbKQNNL (ORCPT ); Tue, 17 Nov 2015 08:13:11 -0500 MIME-Version: 1.0 In-Reply-To: <1434138905-15886-9-git-send-email-pantelis.antoniou@konsulko.com> References: <1434138905-15886-1-git-send-email-pantelis.antoniou@konsulko.com> <1434138905-15886-9-git-send-email-pantelis.antoniou@konsulko.com> Date: Tue, 17 Nov 2015 14:13:10 +0100 X-Google-Sender-Auth: ohyagCyl2w0VZGd0mN-L2TUxzZQ Message-ID: Subject: Re: [PATCH 8/8] of: changesets: Introduce changeset helper methods From: Geert Uytterhoeven To: Pantelis Antoniou Cc: Rob Herring , Grant Likely , Matt Porter , Koen Kooi , Guenter Roeck , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pantelis Antoniou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3138 Lines: 85 Hi Pantelis, On Fri, Jun 12, 2015 at 9:55 PM, Pantelis Antoniou wrote: > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -1028,6 +1028,27 @@ static inline int of_changeset_update_property(struct of_changeset *ocs, > { > return of_changeset_action(ocs, OF_RECONFIG_UPDATE_PROPERTY, np, prop); > } > + > +struct device_node *of_changeset_create_device_nodev( > + struct of_changeset *ocs, struct device_node *parent, > + const char *fmt, va_list vargs); > +__printf(3, 4) struct device_node *of_changeset_create_device_node( > + struct of_changeset *ocs, struct device_node *parent, > + const char *fmt, ...); > +int of_changeset_add_property_copy(struct of_changeset *ocs, > + struct device_node *np, const char *name, > + const void *value, int length); > +int of_changeset_add_property_string(struct of_changeset *ocs, > + struct device_node *np, const char *name, const char *str); > +__printf(4, 5) int of_changeset_add_property_stringf(struct of_changeset *ocs, > + struct device_node *np, const char *name, const char *fmt, ...); > +int of_changeset_add_property_string_list(struct of_changeset *ocs, > + struct device_node *np, const char *name, const char **strs, int count); > +int of_changeset_add_property_u32(struct of_changeset *ocs, > + struct device_node *np, const char *name, u32 val); > +int of_changeset_add_property_bool(struct of_changeset *ocs, > + struct device_node *np, const char *name); > + > #else /* CONFIG_OF_DYNAMIC */ > static inline int of_reconfig_notifier_register(struct notifier_block *nb) > { > @@ -1047,6 +1068,58 @@ static inline int of_reconfig_get_state_change(unsigned long action, > { > return -EINVAL; > } > + > +static inline int of_changeset_create_device_node(struct of_changeset *ocs, > + struct device_node *parent, const char *fmt, ...) > +{ > + return -EINVAL; > +} > + > +int of_changeset_add_property_copy(struct of_changeset *ocs, Missing "static inline". If CONFIG_OF_DYNAMIC=n, you get zillions of: multiple definition of `of_changeset_add_property_copy' multiple definition of `of_changeset_add_property_string' > + struct device_node *np, const char *name, > + const void *value, int length) > +{ > + return -EINVAL; > +} > + > +int of_changeset_add_property_string(struct of_changeset *ocs, Likewise. > + struct device_node *np, const char *name, const char *str) > +{ > + return -EINVAL; > +} Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/