Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753544AbbKQNkB (ORCPT ); Tue, 17 Nov 2015 08:40:01 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:36243 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535AbbKQNkA (ORCPT ); Tue, 17 Nov 2015 08:40:00 -0500 MIME-Version: 1.0 In-Reply-To: <1447273657-1668-2-git-send-email-clabbe.montjoie@gmail.com> References: <1447273657-1668-1-git-send-email-clabbe.montjoie@gmail.com> <1447273657-1668-2-git-send-email-clabbe.montjoie@gmail.com> Date: Tue, 17 Nov 2015 14:39:59 +0100 Message-ID: Subject: Re: [PATCH 2/3] gpio: syscon: fix a possible NULL dereference From: Linus Walleij To: LABBE Corentin Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 19 On Wed, Nov 11, 2015 at 9:27 PM, LABBE Corentin wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later at line 199: > priv->flags = of_id->data; > > Reported-by: coverity (CID 1324140) > Signed-off-by: LABBE Corentin Took out the previously applied version and applied this instead. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/