Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753984AbbKQOGd (ORCPT ); Tue, 17 Nov 2015 09:06:33 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:35328 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753871AbbKQOCV (ORCPT ); Tue, 17 Nov 2015 09:02:21 -0500 MIME-Version: 1.0 In-Reply-To: <20151115040422.GA15180@localhost> References: <20151115040422.GA15180@localhost> Date: Tue, 17 Nov 2015 15:02:20 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: imx1-core: add missing of_node_put From: Linus Walleij To: Vaishali Thakkar Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 37 On Sun, Nov 15, 2015 at 5:04 AM, Vaishali Thakkar wrote: > for_each_child_of_node performs an of_node_get on each iteration, > so of_node_put is required on break out of the loop. > > This is done using Coccinelle. And semantic patch used for this is > as follows: > > @@ > expression root,e; > local idexpression child; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > | > + of_node_put(child); > ? return ...; > ) > ... > } > > Signed-off-by: Vaishali Thakkar Patch applied for fixes, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/