Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbbKQOEj (ORCPT ); Tue, 17 Nov 2015 09:04:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44362 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929AbbKQOEh convert rfc822-to-8bit (ORCPT ); Tue, 17 Nov 2015 09:04:37 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) Subject: Re: [PATCH 2/2] fs/ceph: ceph_frag_contains_value can be boolean From: "Yan, Zheng" In-Reply-To: <1447743139-8190-2-git-send-email-baiyaowei@cmss.chinamobile.com> Date: Tue, 17 Nov 2015 22:04:24 +0800 Cc: Sage Weil , idryomov@gmail.com, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <35E9BBF7-3E75-4889-B8E3-67758754221F@redhat.com> References: <1447743139-8190-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447743139-8190-2-git-send-email-baiyaowei@cmss.chinamobile.com> To: Yaowei Bai Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1235 Lines: 44 > On Nov 17, 2015, at 14:52, Yaowei Bai wrote: > > This patch makes ceph_frag_contains_value return bool to improve > readability due to this particular function only using either one or > zero as its return value. > > No functional change. > > Signed-off-by: Yaowei Bai > --- > include/linux/ceph/ceph_frag.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/ceph/ceph_frag.h b/include/linux/ceph/ceph_frag.h > index 970ba5c..b827e06 100644 > --- a/include/linux/ceph/ceph_frag.h > +++ b/include/linux/ceph/ceph_frag.h > @@ -40,7 +40,7 @@ static inline __u32 ceph_frag_mask_shift(__u32 f) > return 24 - ceph_frag_bits(f); > } > > -static inline int ceph_frag_contains_value(__u32 f, __u32 v) > +static inline bool ceph_frag_contains_value(__u32 f, __u32 v) > { > return (v & ceph_frag_mask(f)) == ceph_frag_value(f); > } > -- > 1.9.1 both applied Thanks Yan, Zheng > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/