Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbbKQOZd (ORCPT ); Tue, 17 Nov 2015 09:25:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57510 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbbKQOZb (ORCPT ); Tue, 17 Nov 2015 09:25:31 -0500 From: Jeff Moyer To: Yaowei Bai Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] fs/block_dev.c: make sb_is_blkdev_sb return bool when CONFIG_BLOCK undefined References: <1447742411-8006-1-git-send-email-baiyaowei@cmss.chinamobile.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 17 Nov 2015 09:25:28 -0500 In-Reply-To: <1447742411-8006-1-git-send-email-baiyaowei@cmss.chinamobile.com> (Yaowei Bai's message of "Tue, 17 Nov 2015 14:40:09 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 38 Yaowei Bai writes: > Currently when CONFIG_BLOCK is defined sb_is_blkdev_sb returns bool, > while when CONFIG_BLOCK is not defined it returns int. Let's keep > consistent to make sb_is_blkdev_sb return bool as well when CONFIG_BLOCK > isn't defined. > > No functional change. > > Signed-off-by: Yaowei Bai Reviewed-by: Jeff Moyer > --- > include/linux/fs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 3aa5142..11505af 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2291,9 +2291,9 @@ static inline void iterate_bdevs(void (*f)(struct block_device *, void *), void > { > } > > -static inline int sb_is_blkdev_sb(struct super_block *sb) > +static inline bool sb_is_blkdev_sb(struct super_block *sb) > { > - return 0; > + return false; > } > #endif > extern int sync_filesystem(struct super_block *); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/