Subject: Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the
 function call "kfree_skb"
To: Marcel Holtmann <marcel@holtmann.org>
References: <5307CAA2.8060406@users.sourceforge.net>
 <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
 <530A086E.8010901@users.sourceforge.net>
 <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
 <530A72AA.3000601@users.sourceforge.net>
 <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
 <530B5FB6.6010207@users.sourceforge.net>
 <alpine.DEB.2.10.1402241710370.2074@hadrien>
 <530C5E18.1020800@users.sourceforge.net>
 <alpine.DEB.2.10.1402251014170.2080@hadrien>
 <530CD2C4.4050903@users.sourceforge.net>
 <alpine.DEB.2.10.1402251840450.7035@hadrien>
 <530CF8FF.8080600@users.sourceforge.net>
 <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
 <530DD06F.4090703@users.sourceforge.net>
 <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
 <5317A59D.4@users.sourceforge.net> <5649D2AE.60100@users.sourceforge.net>
 <5649DE40.6030405@osg.samsung.com>
 <FB4ECAF8-4F55-4F5C-AF13-D402BEE9CE74@holtmann.org>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
        Alexander Aring <alex.aring@gmail.com>, linux-wpan@vger.kernel.org,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: Stefan Schmidt <stefan@osg.samsung.com>
Message-ID: <564B539B.9080003@osg.samsung.com>
Date: Tue, 17 Nov 2015 17:19:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <FB4ECAF8-4F55-4F5C-AF13-D402BEE9CE74@holtmann.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1567
Lines: 44

Hello.

On 17/11/15 15:01, Marcel Holtmann wrote:
> Hi Stefan,
>
>>> The kfree_skb() function tests whether its argument is NULL and then
>>> returns immediately. Thus the test around the call is not needed.
>>>
>>> This issue was detected by using the Coccinelle software.
>>>
>>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>>> ---
>>>   drivers/net/ieee802154/atusb.c | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
>>> index 199a94a..b1cd865 100644
>>> --- a/drivers/net/ieee802154/atusb.c
>>> +++ b/drivers/net/ieee802154/atusb.c
>>> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
>>>   		urb = usb_get_from_anchor(&atusb->idle_urbs);
>>>   		if (!urb)
>>>   			break;
>>> -		if (urb->context)
>>> -			kfree_skb(urb->context);
>>> +		kfree_skb(urb->context);
>>>   		usb_free_urb(urb);
>>>   	}
>>>   }
>> Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
> for some reason I am missing the original patch, can someone resend it please.
>

Done. Resend the original message from my address but with the From line 
intact inside the patch. Please check if it really lists Markus as 
author when applying. Acked-by also resend as reply to the resend patch.

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/