Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754113AbbKQQZK (ORCPT ); Tue, 17 Nov 2015 11:25:10 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:56094 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbbKQQZI (ORCPT ); Tue, 17 Nov 2015 11:25:08 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , Antti Palosaari , linux-kernel@vger.kernel.org Subject: Re: [PATCH] [MEDIA] dvb: usb: fix dib3000mc dependencies Date: Tue, 17 Nov 2015 17:24:23 +0100 Message-ID: <5525192.eyIcy1NRHy@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <3984729.n55BH9Zr8c@wuerfel> References: <3984729.n55BH9Zr8c@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:s68k85rc6lUMetD6O6aBJGMplLCpNvy93Kq758wGmJDVwXwoF92 am491kNi034zoAz4FhesXTeOEUMCSWpzf09NNDlqcfMpHpO0o/H7bZC2PLrRsseZH/+ezeF 2P8aTcVQ1eFRePyWZWEr6yg8shHgRFVoiL9AvWqZuplnR0LLx/lWJlJqU0/Ace8ZHQI+965 vLH/31PjQoXzRHnfOSQrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GpKpIskNNTU=:c3ggSvrgKJWzXHDmEFipux vWJYzIZJEhjXir81fQ+nCBugVvUQ8e78PUHMkwLZiyfYA6Qmt0g/FBmCwNKU8k5nt11nFnto2 /D/864q+XIVrFIgyG4IIyii3nyMAftNm7WwQg9cDJDBBUg1kP+O/MQcS32vmrY4hRm3F9fL75 0rQktuLdVVAxIxsyO0DvJWWNFSpUAXrKkSZhY+vbiOyZcjLtmMixeTrtfuaZz2u0RvMVfkaAR anfip8xV3vbkCIM9ccL2nq3OM9931Lrr9naABTXOk2TTSvuvEPot/nIhD8F5TLqxop3cASdPe e014A73lXt/J8Uz8Ju+5Xx4NBKaOIwP7MREljiy8fz7TmYIUfdFVN8LXYE+eI9xDt1JNB2cX7 uP2BZVA7Hv4JpAVn1+KIaPsTJTNbxvl23xQ25pQ4mF8UFybjszLe085p6Kk4vdDGtNclz06rH K0KvGk6sssUvpbe8z/uRj71cmzTmbCUXSnA/E/SXHxTvEb7acLJ8R0u6eI/M08kTahsmKL2EG 8G7UCM94bOfhnJuBS24nWqRR+tVVNu1Jy2SPphnnDV/QnHdB71uZ+4qiGC7J1PbW7HrN+Ohfd FKZ9yiuS9EM8D6c8V5HKjaoY4bCNrNuY1nieTGdPquFzvrnZIus0vogganVZ0yh+J5Um5LLQi Li/re8NQbI2hAbItcuB/TOkUg3cbhz0BRCZ+lM5VZrn1lDNzheOmfrY+lz0LmCFmMXhELCros D9N27nLL+NaDs0ik Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 27 On Tuesday 17 November 2015 17:17:39 Arnd Bergmann wrote: > The dibusb_read_eeprom_byte function is defined in dibusb-common.c, > but that file is not compiled for CONFIG_DVB_USB_DIBUSB_MB as it > is for the other driver using the common functions, so we can > get a link error: > > drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach': > (.text+0x2c5124): undefined reference to `dibusb_read_eeprom_byte' > (.text+0x2c5134): undefined reference to `dibusb_read_eeprom_byte' > > This changes the Makefile to treat the file like all the others > in this directory, and enforce building dvb-usb-dibusb-common.o > as a dependency. > > Signed-off-by: Arnd Bergmann > I just realized that this depends on another patch I've sent back in April, so that is probably no longer in the patch queue. Please disregard for now. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/