Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754183AbbKQQZ2 (ORCPT ); Tue, 17 Nov 2015 11:25:28 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:14279 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbbKQQZ0 (ORCPT ); Tue, 17 Nov 2015 11:25:26 -0500 Subject: Re: [PATCH v7,1/3] dt-bindings: binding for jz4780-{nand,bch} To: Boris Brezillon References: <1444148837-10770-1-git-send-email-harvey.hunt@imgtec.com> <1444148837-10770-2-git-send-email-harvey.hunt@imgtec.com> <20151104085751.55fbf3c3@bbrezillon> CC: , , "Zubair Lutfullah Kakakhel" , , Alex Smith , "Alex Smith" , Brian Norris , David Woodhouse From: Harvey Hunt Message-ID: <564B54F3.3080603@imgtec.com> Date: Tue, 17 Nov 2015 16:25:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151104085751.55fbf3c3@bbrezillon> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.22] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 36 Hi Boris, On 04/11/15 07:57, Boris Brezillon wrote: > Hi Harvey, > > On Tue, 6 Oct 2015 17:27:15 +0100 > Harvey Hunt wrote: > >> From: Alex Smith >> >> Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, >> as well as the hardware BCH controller, used by the jz4780_{nand,bch} >> drivers. > > Patch 3 does not seem to follow this binding: it still uses the > ingenic,ecc-xxx properties and defines NAND timings. Thanks, I'll fix that for v8. > Also, as answered to patch 3, I think it would be clearer to separate > the nand controller and nand chip representation. That approach makes sense - I'll change it for the next series. > Best Regards, > > Boris Best regards, Harvey Hunt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/