References: <1447099142-10220-1-git-send-email-gratian.crisan@ni.com> <20151109220232.GO17308@twins.programming.kicks-ass.net> <56465279.2010502@intel.com>
User-agent: mu4e 0.9.13; emacs 24.3.1
From: Gratian Crisan <gratian.crisan@ni.com>
To: Dave Hansen <dave.hansen@intel.com>
CC: Peter Zijlstra <peterz@infradead.org>, <gratian.crisan@ni.com>,
        Thomas Gleixner <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
        <x86@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Josh Cartwright <joshc@ni.com>, <gratian@gmail.com>
Subject: Re: [RFC PATCH] tsc: synchronize TSCs on buggy Intel Xeon E5 CPUs with offset error
In-Reply-To: <56465279.2010502@intel.com>
Date: Tue, 17 Nov 2015 10:49:13 -0600
Message-ID: <87poz8fu5y.fsf@spline.amer.corp.natinst.com>
MIME-Version: 1.0
Content-Type: text/plain
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2015 16:49:17.8507 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR04MB852
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1564
Lines: 39


Dave Hansen writes:

> On 11/09/2015 02:02 PM, Peter Zijlstra wrote:
>> On Mon, Nov 09, 2015 at 01:59:02PM -0600, gratian.crisan@ni.com wrote:
>>> The Intel Xeon E5 processor family suffers from errata[1] BT81:
>> 
>>> +#ifdef CONFIG_X86_TSC
>>> +	/*
>>> +	 * Xeon E5 BT81 errata: TSC is not affected by warm reset.
>>> +	 * The TSC registers for CPUs other than CPU0 are not cleared by a warm
>>> +	 * reset resulting in a constant offset error.
>>> +	 */
>>> +	if ((c->x86 == 6) && (c->x86_model == 0x3f))
>>> +		set_cpu_bug(c, X86_BUG_TSC_OFFSET);
>>> +#endif
>> 
>> That's hardly a family, that's just one, Haswell server.
>
> How did you come up with that x86_model?  The document you linked to
> claimes that "Extended Model" is 0010b and "Model Number" is 1101b, so
> the x86_model you are looking for should be 0x2d.

Apologies. I've messed up. The observed behavior seemed to match the
errata and it was a Xeon E5. I've used the model number I read of the
machine exhibiting the behavior w/o properly matching it with the model
number in the errata.

In the meantime Peter Zijlstra pointed me in the right direction i.e. it
looks like the BIOS is changing the TSC_ADJUST for CPU0 but not any of
the other ones. I'll sort it out with our BIOS guys and drop this patch.

Sorry again for the confusion.
-Gratian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/