Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932109AbbKQRGR (ORCPT ); Tue, 17 Nov 2015 12:06:17 -0500 Received: from mail-bn1on0053.outbound.protection.outlook.com ([157.56.110.53]:61531 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932085AbbKQRGJ (ORCPT ); Tue, 17 Nov 2015 12:06:09 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.172) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a68-f790b6d00000123b-91-564b5e7db3b4 Subject: Re: [PATCH 3/9] IB: add a helper to safely drain a QP To: Sagi Grimberg , Christoph Hellwig , References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-4-git-send-email-hch@lst.de> <564851BB.1020004@dev.mellanox.co.il> CC: , , , From: Bart Van Assche Message-ID: <564B5E7D.9030309@sandisk.com> Date: Tue, 17 Nov 2015 09:06:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <564851BB.1020004@dev.mellanox.co.il> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42JZI8azSLc2zjvMoGOxhsX/PcfYLFauPspk cXnXHDaLZ4d6WSy6r+9gs3h9/CmTA5vH9BmbWD0mNr9j99h9s4HN4/MmuQCWKC6blNSczLLU In27BK6MZQ2bWAqmMVd0/37P2MC4k6mLkYNDQsBE4kN/YRcjJ5ApJnHh3no2EFtI4ASjxPQn BV2MXED2DkaJh20HmSGKTCQubj/EBpHYxCjxafVRRpCEsICdxIZrR1lAbBGBHIn/HQehiiYz SixffgqsiFmgQOLbg/9gNpuAkcS39zPBGngFtCT2bJwGtppFQFXi/K137CC2qECExMQJDawQ NYISJ2c+YQG5mhOo98tZSxCTWcBe4sHWMojp8hLb385hBlkrIXCRVWJp2zsWiG/UJU4umc80 gVFkFpJJsxDaZyFpX8DIvIpRLDczpzg3PbXA0FCvODEvJbM4Wy85P3cTIzhiuDJ2MG6dZH6I UYCDUYmHV+C4V5gQa2JZcWXuIUYJDmYlEV5OK+8wId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzW LWphQgLpiSWp2ampBalFMFkmDk6pBkaVe7MKfZR3XFffe7DI4KtdQdP8B2eLb59IfM/35qv0 D85nZq3/puR/rVUKeTfr6Rv72czLnKVlqmK+uR0rnXZ19q9DM6W3ddspZ/GcyBGVKlRb8zKt 2I37dkkcx/797s9X/zac+XThqdYl3P9nCRjx3u1ZeTQ7lik8qc9rn8DmnAy5D1vS1tgosRRn JBpqMRcVJwIAyZutB5QCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphluLIzCtJLcpLzFFi42Lh2siRolsb5x1m0HRG0uL/nmNsFgd/tjFa rFx9lMni8q45bBbPDvWyWHRf38Fm8fr4UyYHdo/pMzaxekxsfsfusftmA5vHtDXnmTw+b5IL YI3isklJzcksSy3St0vgyljWsImlYBpzRffv94wNjDuZuhg5OSQETCQubj/EBmGLSVy4tx7I 5uIQEtjAKNEwZTMzSEJYwE5iw7WjLCC2iECWxPZbC6GKJjNKLF9+ihEkwSyQIfHxzlWwBjYB I4lv72eCNfAKaEns2TgNbAOLgKrE+Vvv2EFsUYEIiYkTGlghagQlTs58AlTPwcEJ1PvlrCXE SFuJO3N3M0PY8hLb385hnsDIPwtJxywkZbOQlC1gZF7FKJabmVOcm55ZYGikV5yYl5JZnK2X nJ+7iREczpxROxivTzQ/xMjEwSnVwOhXO/3als7/F1dUPtf3ktOZF/u66nepxzpDe+5di//d S150YCf3ll0VXDlJutdKBRT9ki6fXtvivSvVZUJZZgxXSN9/u4CWF0orJpmvmNqhobnM4OWt f8ULUjkCi43yiq1rL5sxyN7p5WUTfxu1+5pdwJ3A5QfdZx/YuFZ7zU73dzlac77ZFSuxFGck GmoxFxUnAgBq3FFfFwIAAA== X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD020;1:mr1Xu7lRdMeqfBm0lEAflKOxgslqQu3twOxjE5YhEaKXCgGp862NXn4MJJNES2NcL1dcZGMg3hLlSHnMpWqQey0SfF2f/pW6UA9vKTMGUToP6HbPbdH7qHzIbZaoJL0VcFbjgmJVLUmX3y6yvrIeBrKRbhOVuUlcwQt5fvxsftaQW6w555Hn5VmycqB0dHPp+Z9VtUJnbYSgOOp5NNVrahz4BPwTod7/rfdvVwafDS9KER/s7bueLjk+38sCaJweWKh7yFSARFAXIIdHkEG/kZNOKm5PQ2ig+9b2rRI8JlujEbUsD5koMuXcrpTK2EKGr8NwyLJBbGhHyFq70TGehUC99Hu97IlOZY7PfuH5vgHHI3D3d7TrlH02vB6WcvT9ZJrQcNo0rC1f5wuxE8/aEQ== X-Forefront-Antispam-Report: CIP:63.163.107.172;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(377454003)(164054003)(189002)(24454002)(51884002)(479174004)(199003)(77096005)(230700001)(86362001)(50466002)(59896002)(5008740100001)(586003)(65806001)(47776003)(23746002)(65956001)(2950100001)(106466001)(64126003)(189998001)(81156007)(5001960100002)(4001350100001)(5001920100001)(5001770100001)(97736004)(92566002)(5007970100001)(33656002)(11100500001)(87266999)(76176999)(54356999)(50986999)(65816999)(80316001)(69596002)(83506001)(36756003)(87936001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR02MB1390;H:milsmgep11.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1390;2:779CDTdTDzeD/+gIIJBhuL5FhaAQ76uzRT/6Tzfqjh+iMcm60zoyjlRvYQqfAgDF+IvxV8dmMlLna29yDYmvjjdijJ1LfC2IiLooukOAvH4XRWNpFXRoO4kW+SXSza+TvFrpCrcRi5vRdG/OzdcTZk10O3mADbrF9ceV5mMaWn8=;3:RVUsDu+Gma8LOT79yhgPFa+tnULJBxXcIZUVnRXfa0ZbqL44U6EwULLVZG3cz9qK5NbzDgjrimX5HXzR2WxzINsA1GN37Rz2KYDylghHAcBmBIhh3JgyDEHTk6CMBqeWLPpZCnK8G/UVnquUTbVDqJMxu+yN8a81BMKXlhq+/WMMY2KqmxWKgGIOjx17agiG7LZ5Cf03juwLlrzffdKiKkow2Wxiq1I34JdIXUjZauW5MFTpp49rHvTcu1sinXozeb+ZetyQx7eZW20m9FpTJQ==;25:dykIIVo//iiW5Hdwz/pfhgV8SAc3Q34JMa/vwB+aCPxvUbIjUxcvpIThZ5RIscTEC5ssVDkhV9iG9/eQ7H/3tYd0ylZojv314XxPf5iTylZhe13stGnjjfL6newJd5eic41gTDm2xYO8sVVvy2EINCILvp0fqejkhipaU1mQU/2yUbTXr429I81WpwfoC68BhHs1llIL5CfApT+y6Z8CgB7FWhH8w0zx1X0hXkFcACI8tCSe6mT2bDHiy0TlM11VQic8KtXTzXavAm057hVfAg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:SN1PR02MB1390; X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1390;20:Zc653ZEXQouEDXjS/HY/s15lxu7YiQ5I+951yIyeo1REE+a/EFXdgvqaR0ABlGn6j3c4FlA8Q9J082I86r07mLonicem/tzqMCUT1w85cNc0uNZEq7N/MfvzByoQNvXKrW/TeJ35gCa7hUDRn0POtpPUaelatbuXKr91WF4l6vqvybHSzrxnZPXEzLSAguaojYaK/NRN/bWmj7/1jSUK11c/L1sGSrqLlb0t3+CozQClaKHiFwGQ0Zw094GLYB/MsH1kLDN+VddBSQHSM0gllpHzObB3IcgfLrCU6aZu778ws7OijEteJAw/m4hdVdEHmNJ6yhYoCttsCvoe81AR92ZGDeENal68tk8V2XU5J7WOAodKnx5qddMgXg+NZOi8sVpN3/9fRCLr0r+/dd/Wf9duVni0a680RYvAY3K1Q0I3ujdMVu7xvGh96fT4RTY1KbAUdoEbVjKYv8D5mZv605YNhTqBcpCLtCmSPdSEgiEpivnJJUiNWhSsx34SIqe6;4:AhHx9RJpDXyggxKKUoBrTNxY35yg+DvRdLnWv1CJyLLggo9M5o40PJsg5AnzzkvGnqg9OiOFX5ZGvCer9738TOkwEDpSchIWMWXrcqK1YSI9qY7tKQyUMh3Z3bdOGhP2y1hzqPbGy+jtwZYWZi7d5hTHPDfzkE6L3g+Rm8ndvboZf6fGMpL3IZuYv1rC4lWfZHLU22SnwTT6zA0TgyMpCdfbY34aZeXkJTd0JOv1O9akdxbcqpIWDfJMLUR9NuL+XKWlRsXS83Nl5Sj+6DPSGEhH9EjWN6peJ4gLxe3/dQzve5p/6+0gpuiD67X0OKrhA/LN62WkJdsTBa9PQEfw4ftgmynZBYNBGh1VuU1McuPq40XB+Y9YZbBJKUaCPcSL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:SN1PR02MB1390;BCL:0;PCL:0;RULEID:;SRVR:SN1PR02MB1390; X-Forefront-PRVS: 07630F72AD X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR02MB1390;23:7O8KMRbpzD4fzk0eDfVD1BqysNqLO2SZBqCe2?= =?Windows-1252?Q?E0t5mnQTnXby/jR0MDK3qVRro+rrhBbyICIi2kX6K6LJ83DMshtIOTTC?= =?Windows-1252?Q?5IrUHBx02yH5qU+VAHEONS9CfCLPAVP5L6qejfLyT3l1dytAMAUC92ie?= =?Windows-1252?Q?mBiSDqLEfq7e8yJbMG/439Ls3zYyjz/FInmI0E82yTj5HL9616WeoSno?= =?Windows-1252?Q?j7gr6qa49wTis/rvrfAlGGd30yG9NbXjMY4Q7JaflmOLASenB3JEtrK4?= =?Windows-1252?Q?1BbDA0qZRrO3fSeaTTinyrZprkv1N6cvf3JGKoGIElTEI2zQrP9JBK7Q?= =?Windows-1252?Q?1sL+mb8+Wg37aIyErftM3XOwNmLFn2rSdYxIkp6bMbmdshhQtWSbe10H?= =?Windows-1252?Q?Mm486q/n8A+6QljtAy0+nv8MJljrVA98ELYyaPNXbsjTB/jvZAUy3t4P?= =?Windows-1252?Q?uNfG3narbHOUq/ue5G6/5G1fhkSJmyip3yhnlBQg7KtDbxZZoQEs58oj?= =?Windows-1252?Q?ZnaSu0t3vQIM0AE0z9MqzcuuClhD+o0O3An5QmoPKbCDpR03qXY6gFc1?= =?Windows-1252?Q?qluKh3AktfL/CjjfEyLJHaXpNehflDObcHVhfUhh14joqRq5vZSy8892?= =?Windows-1252?Q?FQ6jXDwwFZV3BeLkODX/7gKTplDRLLdAYE7Byvj99JSfOgkoP8V8tTL1?= =?Windows-1252?Q?nh1w0e5xOR+aQjlUQbXIw0uqk86Ml4zkMw0eYtZZ3bmN7FGsLdq6UTiv?= =?Windows-1252?Q?DRdmwC1xEQb1nnl+tuoPOUWZcB/bdVZAnfAifoHr6Dji2r2MmFgRlaAp?= =?Windows-1252?Q?O/0NiKXYV5o5zALFrlG2H2BdtwHgyV7Ph/f4Jo9Bwdyvcg/eZ0h72lma?= =?Windows-1252?Q?KI07E+k4OEdcBT3iM5txkUby8umR/Pg7broE88dkm48qHnAZTA3dagiC?= =?Windows-1252?Q?u+iNXUA/rCHIyqfvMmist1Kwib3KUmCze4q/po55F1Y2xxIiJTZegsWj?= =?Windows-1252?Q?Fv2HBZaZSBTRP+0en/rOYkh2FEjBl4hL6F/u6UuvtCnY7qBiFr+LO+Qa?= =?Windows-1252?Q?FlAurea1mJuU6Aq5BZGoPFqrtD2xexX21Oe4Mph+IBC3dAgLqhi1lWai?= =?Windows-1252?Q?Gzk2SJImP/OVtWaGAuHmBpget5tYtMhBB1DksSFvesE3hB57q5Dzph3q?= =?Windows-1252?Q?EpbyVxxUhTL9LM+2mXJa/AabXNe9EBuOS1zX4+ZXRLh0lbLNZ56lmOoF?= =?Windows-1252?Q?4knN6pDBXCzR9BYhI4BTGuDEqdbJBYPgNrNCzYGgXuvzOd69VhaG3PJt?= =?Windows-1252?Q?5J/?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR02MB1390;5:JivdHOsCnuurSWIuTSIq3v3246aZ/H93Gyz+oSnalDs8MaaLGEkPD0s8ZyCxdEuHHIx7tHtLjZGrM/1rzGOxbU7s+ZAGf7HL/IHl2juDNfSki54uoRD6DQi1vQYWExZ5FhDATrMCB+/n+vUF2NK55w==;24:ezRvGzZR5EPWgicv2tax/RqpcN1ycSb0NXARUfi/dbxNl+o1hMCbVbhQs/3UqOULcNyCXZM6e3YrQoo8D9yNBZSb9Q+THyhjQBTUoGRhcaE=;20:f7YZ260e0y/UujD4/CHmZi/HZgLfbP+5TSpqx/eL1EZXu0pbqVpUozGG1XUb1YaP3u7u4rXUqO2m18qncsSnOaORy2LAouVpNSGLpcHO+rEzgQkkPCdSmSkDdid88s9YEIY6syVN+01tdpYzIz9LGEPCbu8okRktXJFgqU1Mpc4XJwvwgcMVyOcdIfmY8crDaZJOvAIFOKdIVR3suX5GTmc6cy81rK09dRRtS4FL4zPecvDdfgQKUB/KpIFqLsGF SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2015 17:06:06.1025 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.172];Helo=[milsmgep11.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1390 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 638 Lines: 18 On 11/15/2015 01:34 AM, Sagi Grimberg wrote: > This is taken from srp, and srp drains using a recv wr due to a race > causing a use-after-free condition in srp which re-posts a recv buffer > in the recv completion handler. Hello Sagi, Would it be possible to clarify this ? Does this refer to an existing race or a race that would only occur if the code would be modified ? Thanks, Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/