Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932100AbbKQRKZ (ORCPT ); Tue, 17 Nov 2015 12:10:25 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:54900 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218AbbKQRKX (ORCPT ); Tue, 17 Nov 2015 12:10:23 -0500 Date: Tue, 17 Nov 2015 12:10:21 -0500 (EST) Message-Id: <20151117.121021.367627373283927784.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] net-scm: Delete an unnecessary check before the function call "kfree" From: David Miller In-Reply-To: <564B5937.1070707@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <564B5937.1070707@users.sourceforge.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 17 Nov 2015 09:10:23 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1163 Lines: 34 From: SF Markus Elfring Date: Tue, 17 Nov 2015 17:43:35 +0100 > From: Markus Elfring > Date: Tue, 17 Nov 2015 17:37:22 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring STOP submitting this crap, NOW! I told you I won't review nor apply these patches any more. And ever worse, this one is BUGGY. We're testing p->fp so we know if we can safely dereference it or not. You're adding an OOPS to the kernel. This is why these mindless mechanical transformations are not only often a waste of time, they are dangerous as well. I am silently rejecting from patchwork, immediately, any and all patches you submit of this nature. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/