Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754304AbbKQRfM (ORCPT ); Tue, 17 Nov 2015 12:35:12 -0500 Received: from h2.hallyn.com ([78.46.35.8]:42620 "EHLO h2.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753151AbbKQRfK (ORCPT ); Tue, 17 Nov 2015 12:35:10 -0500 Date: Tue, 17 Nov 2015 11:35:07 -0600 From: "Serge E. Hallyn" To: Yaowei Bai Cc: james.l.morris@oracle.com, serge@hallyn.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] security/capability.h: cap_issubset/isclear can be boolean Message-ID: <20151117173507.GB11708@mail.hallyn.com> References: <1447745124-8580-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447745124-8580-2-git-send-email-baiyaowei@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447745124-8580-2-git-send-email-baiyaowei@cmss.chinamobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2008 Lines: 61 On Tue, Nov 17, 2015 at 03:25:24PM +0800, Yaowei Bai wrote: > This patch makes cap_issubset/isclear return bool due to these > functions only using either one or zero as their return > value. > > No functional change. > > Signed-off-by: Yaowei Bai Acked-by: Serge Hallyn > --- > include/linux/capability.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/linux/capability.h b/include/linux/capability.h > index b032003..f314275 100644 > --- a/include/linux/capability.h > +++ b/include/linux/capability.h > @@ -145,24 +145,24 @@ static inline kernel_cap_t cap_invert(const kernel_cap_t c) > return dest; > } > > -static inline int cap_isclear(const kernel_cap_t a) > +static inline bool cap_isclear(const kernel_cap_t a) > { > unsigned __capi; > CAP_FOR_EACH_U32(__capi) { > if (a.cap[__capi] != 0) > - return 0; > + return false; > } > - return 1; > + return true; > } > > /* > * Check if "a" is a subset of "set". > - * return 1 if ALL of the capabilities in "a" are also in "set" > - * cap_issubset(0101, 1111) will return 1 > - * return 0 if ANY of the capabilities in "a" are not in "set" > - * cap_issubset(1111, 0101) will return 0 > + * return true if ALL of the capabilities in "a" are also in "set" > + * cap_issubset(0101, 1111) will return true > + * return false if ANY of the capabilities in "a" are not in "set" > + * cap_issubset(1111, 0101) will return false > */ > -static inline int cap_issubset(const kernel_cap_t a, const kernel_cap_t set) > +static inline bool cap_issubset(const kernel_cap_t a, const kernel_cap_t set) > { > kernel_cap_t dest; > dest = cap_drop(a, set); > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/