Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932495AbbKQRmP (ORCPT ); Tue, 17 Nov 2015 12:42:15 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36205 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932146AbbKQRmD (ORCPT ); Tue, 17 Nov 2015 12:42:03 -0500 Date: Tue, 17 Nov 2015 17:41:56 +0000 From: Mark Brown To: Joshua Clayton Cc: Jonathan Corbet , Adrian Remonda , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Message-ID: <20151117174156.GX31303@sirena.org.uk> References: <2f17ae29e75967b4522b080c275b907622e1d353.1447773299.git.stillcompiling@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OtXN0xDA1zr/oUEL" Content-Disposition: inline In-Reply-To: <2f17ae29e75967b4522b080c275b907622e1d353.1447773299.git.stillcompiling@gmail.com> X-Cookie: Does the name Pavlov ring a bell? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 37 --OtXN0xDA1zr/oUEL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 17, 2015 at 07:24:21AM -0800, Joshua Clayton wrote: > default_rx and rx are needlessly different. > Use one buffer, local to transmit() Why? This isn't what I'd expect from black boxing the API, from a userspace point of view the transfer is atomic and in an ideal world we'd be able to do direct to/from memory transfers rather than memcpy() into kernel space which means that userspace should assume the transfers are going on simultaneously even if they don't currently. --OtXN0xDA1zr/oUEL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWS2bjAAoJECTWi3JdVIfQJXcH/1xtb1soGkkp/U0p9wpfckQZ Y91S4gmigfDDDjtlQqI+IXXYGVL6AAj43qR3lHUBhFerq7VMrcY1+FmI4Zwew+BS u34ToY0epv3IqChDS/BYryuRPIEHeTkeAMDCqyIpA+zuqOnfLnyu2QdlnBXdSrmZ rrmvadVZnsdxYlH3/toN01op/rzvv3y0A9YlvnHQ3mGsOvbUbqt38r77ECatFJn1 Zz85/38rGJVeyNf9OmXB6GkIg+zbC/qs+TFcTgKX12mH9NYYDeq+F3cW5si9i1KG srkH9UM1+FezOwucaobEaZpX0x38taOWPkR9CL4s/8pYG2HPo0ocI3ta2zxyMsA= =WUfe -----END PGP SIGNATURE----- --OtXN0xDA1zr/oUEL-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/