Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932507AbbKQRnk (ORCPT ); Tue, 17 Nov 2015 12:43:40 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36210 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932357AbbKQRni (ORCPT ); Tue, 17 Nov 2015 12:43:38 -0500 Date: Tue, 17 Nov 2015 17:43:33 +0000 From: Mark Brown To: Joshua Clayton Cc: Jonathan Corbet , Adrian Remonda , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Message-ID: <20151117174333.GY31303@sirena.org.uk> References: <7f2139b27013d77993c6bc2b0a6c94fab01add98.1447773299.git.stillcompiling@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="apSYfA7d5AHMku3c" Content-Disposition: inline In-Reply-To: <7f2139b27013d77993c6bc2b0a6c94fab01add98.1447773299.git.stillcompiling@gmail.com> X-Cookie: Does the name Pavlov ring a bell? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 32 --apSYfA7d5AHMku3c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 17, 2015 at 07:24:22AM -0800, Joshua Clayton wrote: > Put input from string into its own function. Again, why are we doing this? I'm having a hard time seeing what the gain is, the amount of code being moved is tiny. --apSYfA7d5AHMku3c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWS2dEAAoJECTWi3JdVIfQhi4H/3gmd4tqcUxjfwPTSE0Gn429 9FEJvFADV9BtV793Iobxpsh9i8aC83UhpzJesYS2mrxMk8inEu+CZhPM/zk2UfEa AqC+4UnFNrnhnMUzEtwfpVRkVO3aW397fF+2NXWmW31Ks9/2/1IWFjclvLiq88YP ui+fzQAXUXcjMpCs68zSVAiiukW2//j/gthkHMjxEjtFvGt/JJKNQBlpPE7hGGhI QDnF3hjgnERyxjRjp7UxGQjBmgJIxyloLRYGA7hh3/08JhPCEMdlYNBbyuE/LdZB 8XqZuAYOGkkURrUz7QIXgLG/izJKwFln/AsO/eVTiFHvO7jAckKqMmpZRK+QsNM= =ZcDf -----END PGP SIGNATURE----- --apSYfA7d5AHMku3c-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/