Message-ID: <1447782507.6012.22.camel@perches.com>
Subject: Re: [BUG] checkpatch: false positive for commits with quote
 characters
From: Joe Perches <joe@perches.com>
To: Brian Norris <computersforpeace@gmail.com>,
        Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Date: Tue, 17 Nov 2015 09:48:27 -0800
In-Reply-To: <20151116224321.GR8456@google.com>
References: <20151116224321.GR8456@google.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1121
Lines: 33

On Mon, 2015-11-16 at 14:43 -0800, Brian Norris wrote:
> Hi,
> 
> What is the Blessed (TM) style for referencing commits that have quote
> characters in their subject line? e.g., this commit:
> 
> commit 43163022927b6e7d202a7e6f939c3f392465494d
> Author: Brian Norris <computersforpeace@gmail.com>
> Date:   Tue May 19 14:38:22 2015 -0700
> 
>     mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"
> 
> Checkpatch reports false positive errors like this:
> 
>   ERROR: Please use git commit description style 'commit <12+ chars of
>   sha1> ("")'

Hi Brian.

What version of checkpatch are you using?

Using linux-next:

$ git log --stat -p -1 --format=email 43163022927b6e7d202a7e6f939c3f392465494d | ./scripts/checkpatch.pl --strict -
total: 0 errors, 0 warnings, 0 checks, 53 lines checked

Your patch has no obvious style problems and is ready for submission.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/