Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932490AbbKQShS (ORCPT ); Tue, 17 Nov 2015 13:37:18 -0500 Received: from www62.your-server.de ([213.133.104.62]:34532 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126AbbKQShO (ORCPT ); Tue, 17 Nov 2015 13:37:14 -0500 Message-ID: <564B73D7.7040501@iogearbox.net> Date: Tue, 17 Nov 2015 19:37:11 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: SF Markus Elfring , netdev@vger.kernel.org, "David S. Miller" CC: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall , eric.dumazet@gmail.com Subject: Re: net-scm: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <564B5937.1070707@users.sourceforge.net> <564B602F.2020302@iogearbox.net> <564B6C6F.3070809@users.sourceforge.net> In-Reply-To: <564B6C6F.3070809@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 18 On 11/17/2015 07:05 PM, SF Markus Elfring wrote: >> Eric already mentioned that in some situations where it's critical, >> it actually slows down the code, i.e. you'll have an extra >> function call to get there and inside kfree() / kfree_skb() / etc, >> the test is actually marked as unlikely(). > > How do you think about to add similar annotations to any more > source code places? You mean this likely() annotation of yours? It doesn't make any sense to me to place it there, and since you've spend the second thinking about it when adding it to the diff, you should have already realized that your code was buggy ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/