Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754670AbbKQTVT (ORCPT ); Tue, 17 Nov 2015 14:21:19 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33854 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbbKQTVS (ORCPT ); Tue, 17 Nov 2015 14:21:18 -0500 From: Joshua Clayton To: linux-arm-kernel@lists.infradead.org Cc: Mark Brown , Jonathan Corbet , Adrian Remonda , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH 2/8] Documentation/spi/spidev_test.c: clean up input_tx Date: Tue, 17 Nov 2015 11:21:12 -0800 Message-ID: <5345436.HCqatbevmx@jclayton-pc> User-Agent: KMail/5.0.2 (Linux/4.2.0-18-generic; KDE/5.15.0; x86_64; ; ) In-Reply-To: <20151117174333.GY31303@sirena.org.uk> References: <7f2139b27013d77993c6bc2b0a6c94fab01add98.1447773299.git.stillcompiling@gmail.com> <20151117174333.GY31303@sirena.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 20 On Tuesday, November 17, 2015 05:43:33 PM Mark Brown wrote: > On Tue, Nov 17, 2015 at 07:24:22AM -0800, Joshua Clayton wrote: > > Put input from string into its own function. > > Again, why are we doing this? I'm having a hard time seeing what the > gain is, the amount of code being moved is tiny. It takes some clutter out of main() whose scope is limited to that little block of code, and because in the next patch we add another (larger)function to the if/else block. I don't know if it is valid to say "look at the next commit" for justification, but That is the reason. -- ~Joshua Clayton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/