Subject: Re: [PATCH 2/7] misc: eeprom: 93xx46: Add DT bindings to
 eeprom_93xx46 driver.
To: Rob Herring <robh@kernel.org>
References: <1447733796-15546-1-git-send-email-cory.tusar@pid1solutions.com>
 <1447733796-15546-3-git-send-email-cory.tusar@pid1solutions.com>
 <20151117205321.GA7718@rob-hp-laptop>
Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
        galak@codeaurora.org, agust@denx.de, gregkh@linuxfoundation.org,
        jic23@kernel.org, vz@mleia.com, broonie@kernel.org, afd@ti.com,
        andrew@lunn.ch, Chris.Healy@zii.aero, Keith.Vennel@zii.aero,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
From: Cory Tusar <cory.tusar@pid1solutions.com>
Message-ID: <564B98B8.20404@pid1solutions.com>
Date: Tue, 17 Nov 2015 16:14:32 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151117205321.GA7718@rob-hp-laptop>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2528
Lines: 78

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/17/2015 03:53 PM, Rob Herring wrote:
> On Mon, Nov 16, 2015 at 11:16:31PM -0500, Cory Tusar wrote:
>> This commit documents bindings to be added to the eeprom_93xx46 driver
>> which allow device word size and read-only attributes to be specified
>> via devicetree.
>>
>> Currently the only supported device is a generic "eeprom-93xx46", which
>> mirrors the configuration options previously available as a platform
>> device.
>>
>> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
>> ---
>>  .../devicetree/bindings/misc/eeprom-93xx46.txt       | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
>> new file mode 100644
>> index 0000000..ba493a8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
>> @@ -0,0 +1,20 @@
>> +EEPROMs (SPI) compatible with Microchip Technology 93xx46 family.
>> +
>> +Required properties:
>> +- compatible : "eeprom-93xx46"
> 
> This should also have a compatible with the actual manufacturer.

Above and beyond the one that's added later for the specific Atmel part
I've tested with?

>> +- data-size : number of data bits per word (either 8 or 16)
>> +
>> +Optional properties:
>> +- read-only : parameter-less property which disables writes to the EEPROM
>> +
>> +Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt
>> +apply.  In particular, "reg" and "spi-max-frequency" properties must be given.
>> +
>> +Example:
>> +	93c46c@0 {
>> +		compatible = "eeprom-93xx46";
>> +		reg = <0>;
>> +		spi-max-frequency = <1000000>;
>> +		spi-cs-high;
>> +		data-size = <8>;
>> +	};
>> -- 
>> 2.4.10
>>


- -- 
Cory Tusar
Principal
PID 1 Solutions, Inc.


"There are two ways of constructing a software design.  One way is to
 make it so simple that there are obviously no deficiencies, and the
 other way is to make it so complicated that there are no obvious
 deficiencies."  --Sir Charles Anthony Richard Hoare

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlZLmLgACgkQHT1tsfGwHJ/HTgCgjgtEntrpZNlGyHMjw3EPuOLT
ZJ4AnRQPgOjG5IouJIXURjlkNGor9Npl
=8pqx
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/