Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754866AbbKQVPf (ORCPT ); Tue, 17 Nov 2015 16:15:35 -0500 Received: from mail-qg0-f54.google.com ([209.85.192.54]:36295 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753892AbbKQVPd (ORCPT ); Tue, 17 Nov 2015 16:15:33 -0500 Subject: Re: [PATCH 4/7] misc: eeprom: 93xx46: Add DT binding for Atmel AT93C46D devices. To: Rob Herring References: <1447733796-15546-1-git-send-email-cory.tusar@pid1solutions.com> <1447733796-15546-5-git-send-email-cory.tusar@pid1solutions.com> <20151117205652.GA8990@rob-hp-laptop> Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, agust@denx.de, gregkh@linuxfoundation.org, jic23@kernel.org, vz@mleia.com, broonie@kernel.org, afd@ti.com, andrew@lunn.ch, Chris.Healy@zii.aero, Keith.Vennel@zii.aero, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Cory Tusar Message-ID: <564B98F2.6060705@pid1solutions.com> Date: Tue, 17 Nov 2015 16:15:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151117205652.GA8990@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2021 Lines: 64 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/17/2015 03:56 PM, Rob Herring wrote: > On Mon, Nov 16, 2015 at 11:16:33PM -0500, Cory Tusar wrote: >> This commit adds a compatible string to the eeprom_93xx46 devicetree >> bindings in support of Atmel AT93C46D devices. >> >> Signed-off-by: Cory Tusar >> --- >> Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt >> index ba493a8..34a0cc2 100644 >> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt >> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt >> @@ -1,7 +1,7 @@ >> EEPROMs (SPI) compatible with Microchip Technology 93xx46 family. >> >> Required properties: >> -- compatible : "eeprom-93xx46" >> +- compatible : "eeprom-93xx46", "atmel,at93c46d" > > This needs to be clear that it should be the opposite order. Something > like this: > > compatible: One of the following: > "atmel,at93c46d" > Followed by "eeprom-93xx46" Will fix, thanks. >> - data-size : number of data bits per word (either 8 or 16) >> >> Optional properties: >> -- >> 2.4.10 >> - -- Cory Tusar Principal PID 1 Solutions, Inc. "There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies, and the other way is to make it so complicated that there are no obvious deficiencies." --Sir Charles Anthony Richard Hoare -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlZLmPIACgkQHT1tsfGwHJ9FrACeKfmCgXePFz/N3v9QMV7c4ASj SxcAnREBHu6lR5iAeyAtLpz8UCOOtDbn =EfAl -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/