Date: Tue, 17 Nov 2015 16:25:54 -0500 (EST)
Message-Id: <20151117.162554.314531574043190960.davem@davemloft.net>
To: tj@kernel.org
Cc: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu,
        lizefan@huawei.com, hannes@cmpxchg.org, netdev@vger.kernel.org,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@fb.com, daniel@iogearbox.net, daniel.wagner@bmw-carit.de,
        nhorman@tuxdriver.com
Subject: Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup
From: David Miller <davem@davemloft.net>
In-Reply-To: <1447789240-29394-5-git-send-email-tj@kernel.org>
References: <1447789240-29394-1-git-send-email-tj@kernel.org>
	<1447789240-29394-5-git-send-email-tj@kernel.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 907
Lines: 19

From: Tejun Heo <tj@kernel.org>
Date: Tue, 17 Nov 2015 14:40:39 -0500

> In preparation, this patch adds sock->sk_cgroup which points to the
> associated cgroup.  A sock is associated on creation and stays
> associated to the same cgroup until freed; unfortunately, this ends up
> adding another cgroup field to struct sock on top of sk_cgrp_prioidx
> and sk_classid.  I tried to think of a way to somehow overload the
> existing fields but couldn't come up with a reasonable one.

sk->sk_cgrp_prioidx is simply sk->sk_cgroup->id, is it not?

We really need to consolidate this before we stuff even more members
into the socket for control group support, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/