Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932419AbbKQVjJ (ORCPT ); Tue, 17 Nov 2015 16:39:09 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:41234 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753050AbbKQVjI (ORCPT ); Tue, 17 Nov 2015 16:39:08 -0500 From: Felipe Balbi To: Arnd Bergmann , Peter Chen , CC: , , Subject: Re: [PATCH] USB: USB_OTG does not depend on PM In-Reply-To: <7521777.8ZmnT3AlIC@wuerfel> References: <7521777.8ZmnT3AlIC@wuerfel> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 17 Nov 2015 15:38:33 -0600 Message-ID: <874mgkjoh2.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2200 Lines: 59 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Arnd Bergmann writes: > USB_OTG initially depended on USB_SUSPEND, which was later turned into > PM_RUNTIME and finally into PM. I don't know at what point the dependency > became unnecessary but it appears to work fine without CONFIG_PM now. > > However, we get lots of warnings in randconfig kernels like: > > warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG whic= h has unmet direct dependencies (USB_SUPPORT && USB && PM) > > whenever CONFIG_PM is disabled and something else selects USB_OTG. > Let's just drop the dependency to avoid the warnings. > > Signed-off-by: Arnd Bergmann > --- > I keep seeing this one in my ARM randconfig test and how did you test this ? Did you make sure you're not breaking HNP ? For HNP to happen we depend on a bus_suspend and bus_suspend is only available on CONFIG_PM, unless that has changed. Seems like you've only compile tested this patch, is that correct ? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWS55aAAoJEIaOsuA1yqREDxYQAKqXJtUroS7Q8P9KpzUcUwxp yuz/0anWcyyRvFnM5T2qgH9Ho8GtQQr7Ik3fZqGBQIT8MvoTzVx/Qgg9gEURJIbb FIpxHAcCVmK8UQRJF+ji19LHbugyUsff1AIrHOoJ+t+8h0J2hHa4c92t3cPjsEmk cD3psa6Nggry6E651sC7Tacsa2TL3MjChE3bOe7Bjh3UZyrR21A3MZBY7mNDX56m Qxh6mWO8fsvy4S+ICFjWOgM653omJrakI5/lYMdcH84IKxmwlbTXau9PSmiT8jVN 2Z3slW21CKPyU1m37Y6mgIOLEL/BWcR0qtSINsYUR860TWQRSKpVz6Th31aZpXAH IAvigE8eZEqhPsoRkflvIKaincqiJffS4868Y1TuJ3wlUfXWq7J+HdoYmY03rAnm yIRcvWaykBu12XY3Bo+67pmHeX1Ib2k5eK1PvtOkOyqbQjn1X+iKAIWEzWjhM+7y dwjM0lthwIw4qxjC2//JigpNWjhrO/7x85rgJP09wmzzdY3KB2VGs787a/n6Nksn 5t2pbzN6L/kghXTHtPtCKinixU7wi0rA9NYBGGGGnkTxRqZmdkPfEAspQ7DviXtx 9wiC80XqkJK8/aty/S+bs08Cwt/qu1RDHicaq0DKCFldOB+DUq5vhP4cu7McnhAo nFYewtH/0+6GkDcw38nJ =dnYU -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/