Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932420AbbKQWVm (ORCPT ); Tue, 17 Nov 2015 17:21:42 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:43045 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbbKQWVk (ORCPT ); Tue, 17 Nov 2015 17:21:40 -0500 From: Felipe Balbi To: Arnd Bergmann CC: Peter Chen , , , , Subject: Re: [PATCH] USB: USB_OTG does not depend on PM In-Reply-To: <5647698.81XCu85L5D@wuerfel> References: <7521777.8ZmnT3AlIC@wuerfel> <874mgkjoh2.fsf@saruman.tx.rr.com> <5647698.81XCu85L5D@wuerfel> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 17 Nov 2015 16:21:06 -0600 Message-ID: <871tbojmi5.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2719 Lines: 71 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Arnd Bergmann writes: > On Tuesday 17 November 2015 15:38:33 Felipe Balbi wrote: >>=20 >> Arnd Bergmann writes: >> > USB_OTG initially depended on USB_SUSPEND, which was later turned into >> > PM_RUNTIME and finally into PM. I don't know at what point the depende= ncy >> > became unnecessary but it appears to work fine without CONFIG_PM now. >> > >> > However, we get lots of warnings in randconfig kernels like: >> > >> > warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG w= hich has unmet direct dependencies (USB_SUPPORT && USB && PM) >> > >> > whenever CONFIG_PM is disabled and something else selects USB_OTG. >> > Let's just drop the dependency to avoid the warnings. >> > >> > Signed-off-by: Arnd Bergmann >> > --- >> > I keep seeing this one in my ARM randconfig test >>=20 >> and how did you test this ? Did you make sure you're not breaking HNP ? >> For HNP to happen we depend on a bus_suspend and bus_suspend is only >> available on CONFIG_PM, unless that has changed. >>=20 >> Seems like you've only compile tested this patch, is that correct ? > > Yes, I compile-tested only and inspected the code briefly without finding > anything that contradicted this. It seems I missed the important part > as you say, so we should instead add 'depends on PM' for the other > symbols. right, that might be better. I'll still read that code again, it has been a few years since I looked at hnp at all. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWS6hTAAoJEIaOsuA1yqRErRUP/RMa8FMFvy6Xw9vEI612mnpe hBLrr4/80ttcSGX4Irbu2F5pXUIfefl3ukjStPkOh0ZF1GOQbzsnMNUmMGyy4fGm iE8x/AiuCw9iFVOCcNDHgPnBWmpspdj7HUBc4qk9GwqAF4v7OH2CUE4o/zMnwBy2 m1gOX6bKQMS/9ar3lWL5ySK09IWXXOscHkXbH1iz/Iizqkj+Srlm1RH2GkDZk3f0 WXwGvJTMrJ8wIrphwhY1LJRiSypw0KIzFLpBGJaQhUYSNr+DWKd3IwWNh5uH52Ez inLwJbOxaAYDRwXC/XCAmAQvv2eaUveBrWfoPwbUc+cjInBBq1QL4rVTZLoqCHnV h8wNxA5gr+p4HMRuw1BziEgqizEdcSvfEEJNWMmxTQxdN2m0XoEtphhIPlQ2s2+f SYmz8bfNwooXRSGd4w4YmjEVcXAkBzEpM7kgHtI0lMcHbEIDYgGgydPCu9bJH+Jp KPhPU/C6Mv7YZar+LGj6uIvYcOJTFpo3WY0nRyz0+dkPsD6ItmoznY9eQ+coCF4r 30fpZY7AIga+zpR+dVnuYkG2NlYlSlhMsk/4O2xZ3lzWJ1YPdvN6vizBgoY8VBL+ CnHxe6mgOBt9qOM77vO4c1TYM1B41a5OaKS2tUSo736xmHMLxRoY+yr2b+f6a+qf vyEFG0J2iCuh/65whTKw =R8vy -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/