Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755016AbbKQXJa (ORCPT ); Tue, 17 Nov 2015 18:09:30 -0500 Received: from mail-yk0-f169.google.com ([209.85.160.169]:35872 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbbKQXJ2 (ORCPT ); Tue, 17 Nov 2015 18:09:28 -0500 Date: Tue, 17 Nov 2015 18:09:24 -0500 From: Tejun Heo To: Jan Engelhardt Cc: davem@davemloft.net, pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, lizefan@huawei.com, hannes@cmpxchg.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, daniel@iogearbox.net, daniel.wagner@bmw-carit.de, nhorman@tuxdriver.com Subject: Re: [PATCH iptables] libxt_cgroup2: add support for cgroup2 path matching Message-ID: <20151117230924.GL22864@mtj.duckdns.org> References: <1447789240-29394-1-git-send-email-tj@kernel.org> <20151117194221.GB22864@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 49 Hello, On Wed, Nov 18, 2015 at 12:02:01AM +0100, Jan Engelhardt wrote: > On Tuesday 2015-11-17 20:42, Tejun Heo wrote: > >+static void cgroup2_save(const void *ip, const struct xt_entry_match *match) > >+{ > >+ const struct xt_cgroup2_info *info = (void *)match->data; > >+ > >+ printf("%s --path %s", info->invert ? " !" : "", info->path); > >+} > > Can cgroup path names contain anything fancy, like spaces, backslashes, etc.? > If so, xtables_save_string() will be needed here. Will update. > >+static struct xtables_match cgroup2_match = { > >+ .family = NFPROTO_UNSPEC, > >+ .name = "cgroup2", > >+ .version = XTABLES_VERSION, > >+ .size = XT_ALIGN(sizeof(struct xt_cgroup2_info)), > >+ .userspacesize = XT_ALIGN(sizeof(struct xt_cgroup2_info)), > > userspacesize must not include xt_cgroup2_info.priv. > Change to offsetof(...), cf. other .c modules which do this. Ah, okay. ... > >+\fBIMPORTANT\fP: when being used in the INPUT chain, the cgroup2 > >+matcher is currently only of limited functionality, meaning it > >+will only match on packets that are processed for local sockets > >+through early socket demuxing. Therefore, general usage on the > >+INPUT chain is disadviced unless the implications are well > > is disadviced (sic) -> is not advised Will update. That's copied verbatim from xt_cgroup tho. Will create a patch to update that too. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/