Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755197AbbKRBmb (ORCPT ); Tue, 17 Nov 2015 20:42:31 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:50757 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754308AbbKRBm3 (ORCPT ); Tue, 17 Nov 2015 20:42:29 -0500 Message-ID: <564BD770.1080205@hisilicon.com> Date: Wed, 18 Nov 2015 09:42:08 +0800 From: huangdaode User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Arnd Bergmann CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 net-next] net: hisilicon: fix binding document of mdio References: <1447666704-200773-1-git-send-email-huangdaode@hisilicon.com> <6897029.2fyR9qGpEn@wuerfel> In-Reply-To: <6897029.2fyR9qGpEn@wuerfel> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.13.165] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.564BD780.0073,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 23b226ffb6f7ad4580ebda86a6281287 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2080 Lines: 64 On 2015/11/16 17:38, Arnd Bergmann wrote: > On Monday 16 November 2015 17:38:24 huangdaode wrote: >> This patch explains the occasion of "hisilcon,mdio" and >> "hisilicon,hns-mdio" according to Arnd's comments. >> and reformat it according to comments from Rob. >> >> chang log: >> >> v2: >> 1) reformat the style. >> 2) make it more clearity. >> >> v1: >> initial version. >> >> Signed-off-by: huangdaode >> --- > The new version looks ok, but your changelog above is formatted > incorrectly. Please put only the contents you want in the git history > above the '---' line and your Signed-off-by, but put the parts that > refer to previous versions of the submission below the ---. Got it. thanks Arnd. Daode >> Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt >> index 9c23fdf..4942d20 100644 >> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt >> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt >> @@ -1,7 +1,12 @@ >> Hisilicon MDIO bus controller >> >> Properties: >> -- compatible: "hisilicon,mdio","hisilicon,hns-mdio". >> +- compatible: can be one of: >> + "hisilicon,hns-mdio" >> + "hisilicon,mdio" >> + "hisilicon,hns-mdio" is recommendly to be used for hip05 and later SOCs, >> + while "hisilicon,mdio" is optional for backwards compatibility, only >> + support for hip04 Soc. >> - reg: The base address of the MDIO bus controller register bank. >> - #address-cells: Must be <1>. >> - #size-cells: Must be <0>. MDIO addresses have no size component. >> > > . > -- Best Regards Daode Huang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/