Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754617AbbKRCv3 (ORCPT ); Tue, 17 Nov 2015 21:51:29 -0500 Received: from mga14.intel.com ([192.55.52.115]:53321 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbbKRCv1 (ORCPT ); Tue, 17 Nov 2015 21:51:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,310,1444719600"; d="scan'208";a="853468633" Subject: Re: [PATCH 02/10] KVM: x86: MMU: Add helper function to clear a bit in unsync child bitmap To: Takuya Yoshikawa , pbonzini@redhat.com References: <20151112204849.ba920599a8426d7196a0df73@lab.ntt.co.jp> <20151112205019.611e8216adebb465b689876e@lab.ntt.co.jp> Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Xiao Guangrong Message-ID: <564BE628.1050705@linux.intel.com> Date: Wed, 18 Nov 2015 10:44:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151112205019.611e8216adebb465b689876e@lab.ntt.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 34 On 11/12/2015 07:50 PM, Takuya Yoshikawa wrote: > + if (!ret) { > + clear_unsync_child_bit(sp, i); > + continue; > + } else if (ret > 0) { > nr_unsync_leaf += ret; Just a single line here, braces are unnecessary. > - else > + } else > return ret; > } else if (child->unsync) { > nr_unsync_leaf++; > if (mmu_pages_add(pvec, child, i)) > return -ENOSPC; > } else > - goto clear_child_bitmap; > - > - continue; > - > -clear_child_bitmap: > - __clear_bit(i, sp->unsync_child_bitmap); > - sp->unsync_children--; > - WARN_ON((int)sp->unsync_children < 0); > + clear_unsync_child_bit(sp, i); > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/