Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755316AbbKRIBH (ORCPT ); Wed, 18 Nov 2015 03:01:07 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34461 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbbKRIBD (ORCPT ); Wed, 18 Nov 2015 03:01:03 -0500 From: LABBE Corentin To: jdelvare@suse.com, wsa@the-dreams.de Cc: LABBE Corentin , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8 Date: Wed, 18 Nov 2015 09:00:53 +0100 Message-Id: <1447833653-28387-2-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1447833653-28387-1-git-send-email-clabbe.montjoie@gmail.com> References: <1447833653-28387-1-git-send-email-clabbe.montjoie@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 44 The simple_strtoul function is marked as obsolete. This patch replace it by kstrtou8. Signed-off-by: LABBE Corentin --- drivers/i2c/busses/i2c-taos-evm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c index 4c7fc2d..552f127 100644 --- a/drivers/i2c/busses/i2c-taos-evm.c +++ b/drivers/i2c/busses/i2c-taos-evm.c @@ -70,6 +70,7 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, struct serio *serio = adapter->algo_data; struct taos_data *taos = serio_get_drvdata(serio); char *p; + int err; /* Encode our transaction. "@" is for the device address, "$" for the SMBus command and "#" for the data. */ @@ -130,7 +131,14 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, return 0; } else { if (p[0] == 'x') { - data->byte = simple_strtol(p + 1, NULL, 16); + /* + * voluntary dropping error code of kstrtou8 since all + * error code that it could return are invalid according + * to Documentation/i2c/fault-codes + */ + err = kstrtou8(p + 1, 16, &data->byte); + if (err) + return -EPROTO; return 0; } } -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/