Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932586AbbKRIZp (ORCPT ); Wed, 18 Nov 2015 03:25:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:39132 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932465AbbKRIZm (ORCPT ); Wed, 18 Nov 2015 03:25:42 -0500 From: Andreas Schwab To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Yury Norov , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, Nathan_Lynch@mentor.com, agraf@suse.de, klimov.linux@gmail.com, broonie@kernel.org, jan.dakinevich@gmail.com, ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, andrey.konovalov@linaro.org, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH v6 15/19] arm64: ilp32: force IPC_64 in msgctl, shmctl, semctl References: <1447795019-30176-1-git-send-email-ynorov@caviumnetworks.com> <1447795019-30176-16-git-send-email-ynorov@caviumnetworks.com> <26387039.NNJ6EnRrv8@wuerfel> X-Yow: Sometime in 1993 NANCY SINATRA will lead a BLOODLESS COUP on GUAM!! Date: Wed, 18 Nov 2015 09:25:40 +0100 In-Reply-To: <26387039.NNJ6EnRrv8@wuerfel> (Arnd Bergmann's message of "Tue, 17 Nov 2015 23:07:03 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1509 Lines: 42 Arnd Bergmann writes: > On Wednesday 18 November 2015 00:16:55 Yury Norov wrote: >> >> +/* IPC_64 */ >> +asmlinkage long ilp32_sys_msgctl(int first, int second, void __user *uptr) >> +{ >> + return compat_sys_msgctl(first, second | IPC_64, uptr); >> +} >> +#define compat_sys_msgctl ilp32_sys_msgctl >> + >> +asmlinkage long ilp32_sys_shmctl(int first, int second, void __user *uptr) >> +{ >> + return compat_sys_shmctl(first, second | IPC_64, uptr); >> +} >> +#define compat_sys_shmctl ilp32_sys_shmctl >> + >> +asmlinkage long ilp32_sys_semctl(int first, int second, int third, int arg) >> +{ >> + return compat_sys_semctl(first, second, third | IPC_64, arg); >> +} >> +#define compat_sys_semctl ilp32_sys_semctl >> > > I wonder if this would be any simpler by changing compat_ipc_parse_version() This cries for a generic solution. Other archs migrating to separate ipc syscalls will want to avoid the whole IPC_64 business for them, even if they need to retain [compat_]ipc_parse_version for sys_ipc compatibility. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/