Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932939AbbKRJLT (ORCPT ); Wed, 18 Nov 2015 04:11:19 -0500 Received: from smtp-1b.atlantis.sk ([80.94.52.26]:58032 "EHLO smtp-1b.atlantis.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755246AbbKRJKq (ORCPT ); Wed, 18 Nov 2015 04:10:46 -0500 From: Ondrej Zary To: Francois Romieu Subject: Re: [PATCH 3/3] dl2k: Implement suspend Date: Wed, 18 Nov 2015 10:10:41 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: netdev@vger.kernel.org, David Miller , Kernel development list , "Rafael J. Wysocki" References: <1447781298-19785-1-git-send-email-linux@rainbow-software.org> <1447781298-19785-3-git-send-email-linux@rainbow-software.org> <20151117225610.GB3362@electric-eye.fr.zoreil.com> In-Reply-To: <20151117225610.GB3362@electric-eye.fr.zoreil.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201511181010.41920.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1916 Lines: 66 On Tuesday 17 November 2015, Francois Romieu wrote: > Ondrej Zary : > [...] > > > diff --git a/drivers/net/ethernet/dlink/dl2k.c > > b/drivers/net/ethernet/dlink/dl2k.c index 9e9baa0..b53dfa7 100644 > > --- a/drivers/net/ethernet/dlink/dl2k.c > > +++ b/drivers/net/ethernet/dlink/dl2k.c > > @@ -1824,11 +1824,57 @@ rio_remove1 (struct pci_dev *pdev) > > } > > } > > > > +#ifdef CONFIG_PM > > +static int rio_suspend(struct pci_dev *pdev, pm_message_t state) > > +{ > > + struct net_device *dev = pci_get_drvdata(pdev); > > + struct netdev_private *np = netdev_priv(dev); > > + > > + pci_save_state(pdev); > > Cargo-cultism ? > > > + > > + if (netif_running(dev)) { > > + netif_device_detach(dev); > > + del_timer_sync(&np->timer); > > + rio_hw_stop(dev); > > + free_list(dev); > > If free_list is used here, so must alloc_list be in resume, whence > an extra failure opportunity. > > You may not need to free both Tx and Rx here. I'll better drop the free_list/alloc_list from suspend/resume (as you suggested before). > [...] > > > static struct pci_driver rio_driver = { > > .name = "dl2k", > > .id_table = rio_pci_tbl, > > .probe = rio_probe1, > > .remove = rio_remove1, > > +#ifdef CONFIG_PM > > + .suspend = rio_suspend, > > + .resume = rio_resume, > > +#endif /* CONFIG_PM */ > > It looks a bit old school. > > See Documentation/power/pci.txt and drivers/net/ethernet/via/via-rhine.c > for an instance of SIMPLE_DEV_PM_OPS. > > At some point you'll probably support runtime power management though. Thanks for suggestion, I've been looking at the wrong drivers as none of them used dev_pm_ops. -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/