Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932436AbbKRJjr (ORCPT ); Wed, 18 Nov 2015 04:39:47 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38480 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755390AbbKRJjo (ORCPT ); Wed, 18 Nov 2015 04:39:44 -0500 Date: Wed, 18 Nov 2015 10:39:40 +0100 From: LABBE Corentin To: Jean Delvare Cc: LABBE Corentin , wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] i2c: taos-evm: replace simple_strtoul by kstrtou8 Message-ID: <20151118093940.GA1126@Red> References: <1447833653-28387-1-git-send-email-clabbe.montjoie@gmail.com> <1447833653-28387-2-git-send-email-clabbe.montjoie@gmail.com> <20151118102954.5c3b0121@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151118102954.5c3b0121@endymion.delvare> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2090 Lines: 62 On Wed, Nov 18, 2015 at 10:29:54AM +0100, Jean Delvare wrote: > Hi Corentin, > > On Wed, 18 Nov 2015 09:00:53 +0100, LABBE Corentin wrote: > > The simple_strtoul function is marked as obsolete. > > This patch replace it by kstrtou8. > > > > Signed-off-by: LABBE Corentin > > --- > > drivers/i2c/busses/i2c-taos-evm.c | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c > > index 4c7fc2d..552f127 100644 > > --- a/drivers/i2c/busses/i2c-taos-evm.c > > +++ b/drivers/i2c/busses/i2c-taos-evm.c > > @@ -70,6 +70,7 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > > struct serio *serio = adapter->algo_data; > > struct taos_data *taos = serio_get_drvdata(serio); > > char *p; > > + int err; > > > > /* Encode our transaction. "@" is for the device address, "$" for the > > SMBus command and "#" for the data. */ > > @@ -130,7 +131,14 @@ static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, > > return 0; > > } else { > > if (p[0] == 'x') { > > - data->byte = simple_strtol(p + 1, NULL, 16); > > + /* > > + * voluntary dropping error code of kstrtou8 since all > > "Voluntarily" or "Willingly" would be more correct. > > > + * error code that it could return are invalid according > > + * to Documentation/i2c/fault-codes > > + */ > > + err = kstrtou8(p + 1, 16, &data->byte); > > + if (err) > > + return -EPROTO; > > return 0; > > } > > } > > Thanks for the patch. Note that you don't strictly need the "err" > variable as you never use its value. > > Reviewed-by: Jean Delvare > Tested-by: Jean Delvare > Thanks I will send a v3 without the err and the spell fix. Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/