Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755500AbbKRKKL (ORCPT ); Wed, 18 Nov 2015 05:10:11 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37658 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932464AbbKRKKH (ORCPT ); Wed, 18 Nov 2015 05:10:07 -0500 MIME-Version: 1.0 In-Reply-To: <1447839706-3192-1-git-send-email-allen_hung@dell.com> References: <1447839706-3192-1-git-send-email-allen_hung@dell.com> Date: Wed, 18 Nov 2015 11:10:05 +0100 Message-ID: Subject: Re: [PATCH 1/1] HID: multitouch: enable palm rejection if device implements confidence usage From: Benjamin Tissoires To: Allen Hung Cc: Jiri Kosina , LKML , linux-input Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2205 Lines: 54 On Wed, Nov 18, 2015 at 10:41 AM, Allen Hung wrote: > The usage Confidence is mandary to Windows Precision Touchpad devices. The > appearance of this usage is checked in hidinput_connect but the quirk > MT_QUIRK_VALID_IS_CONFIDENCE is not applied to the device accordingly. > Apply this quirk and also remove quirk MT_QUIRK_ALWAYS_VALID to enable the > palm rejection for the devices which implement the usage confidence in its > input reports. > > Tested on Dell XPS 13 laptop. > > Signed-off-by: Allen Hung > --- > drivers/hid/hid-multitouch.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 426b2f1..661de1d 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -448,6 +448,8 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi, > mt_store_field(usage, td, hi); > return 1; > case HID_DG_CONFIDENCE: > + cls->quirks &= ~MT_QUIRK_ALWAYS_VALID; > + cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE; NACK: you are going to break a *lot* of multitouch panels with this change. Please target the modification to only touchpads that are following the Precision Touchpad spec. Even there, I will need to be sure that there will be no side effect, but we will have a much thiner spectre than blindly enabling this. For the record, Windows 7 touchscreens used to put any meaning in the confidence tag. Cheers, Benjamin > mt_store_field(usage, td, hi); > return 1; > case HID_DG_TIPSWITCH: > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/