From: David Laight <David.Laight@ACULAB.COM>
To: "'Baolin Wang'" <baolin.wang@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
CC: Felipe Balbi <balbi@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "r.baldyga@samsung.com" <r.baldyga@samsung.com>,
        "fabio.estevam@freescale.com" <fabio.estevam@freescale.com>,
        Philip Oberstaller <Philip.Oberstaller@septentrio.com>,
        Peter Hurley <peter@hurleysoftware.com>,
        "scottwood@freescale.com" <scottwood@freescale.com>,
        Mark Brown <broonie@kernel.org>, USB <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: gadget: Add the console support for usb-to-serial
 port
Thread-Topic: [PATCH] usb: gadget: Add the console support for usb-to-serial
 port
Thread-Index: AQHRIe3+xdFoq8zvHUCNPZkRquVhoJ6hroNA
Date: Wed, 18 Nov 2015 12:05:59 +0000
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBD539B@AcuExch.aculab.com>
References: <a69635e749f96fc9f67e93986edb9942ac0ae59f.1447656764.git.baolin.wang@linaro.org>
	<CAHp75VeSWGShbc3p7xKYjZqqTotoMMMsc1_1BDxtxm1_2hNMbw@mail.gmail.com>
	<CAMz4ku+JYFLt6H-Lvm_KbEX3iHNqzdBynUp2mAZhdaB9dsv0CA@mail.gmail.com>
	<CAHp75VcrxjXTuRyBHDeH8i=DBbfgYoK5_yVJXpXQZrM2vr_wsg@mail.gmail.com>
 <CAMz4ku+v9vZ-6m+hQmxy6wERpQaOe8fSGetGd=Qt9oLoEis+Zw@mail.gmail.com>
In-Reply-To: <CAMz4ku+v9vZ-6m+hQmxy6wERpQaOe8fSGetGd=Qt9oLoEis+Zw@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1821
Lines: 43

From: Baolin Wang
> Sent: 18 November 2015 10:45
> On 18 November 2015 at 17:32, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Wed, Nov 18, 2015 at 4:15 AM, Baolin Wang <baolin.wang@linaro.org> wrote:
> >> On 17 November 2015 at 21:34, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> >>> On Mon, Nov 16, 2015 at 9:05 AM, Baolin Wang <baolin.wang@linaro.org> wrote:
> >>>> It dose not work when we want to use the usb-to-serial port based
> >>>> on one usb gadget as a console. Thus this patch adds the console
> >>>> initialization to support this request.
> >>>
> >
> >>>> +#define GS_BUFFER_SIZE         (4096)
> >>> Redundant parens
> >> OK. I'll remove it.
> >>
> >>>> +#define GS_CONSOLE_BUF_SIZE    (2 * GS_BUFFER_SIZE)
> >>>> +
> >>>> +struct gscons_info {
> >>>> +       struct gs_port          *port;
> >>>> +       struct tty_driver       *tty_driver;
> >>>> +       struct work_struct      work;
> >>>> +       int                     buf_tail;
> >>>> +       char                    buf[GS_CONSOLE_BUF_SIZE];
> >>>
> >>> Can't be malloced once?
> >> The 'gscons_info' structure is malloced once.
> >
> > In state of high fragmentation is quite hard to find big memory chunks.
> > I would split it to two allocations, though if maintainers are okay
> > with your code, then I'm also okay.
> >
> 
> Make sense. But I think the major memory of the 'struct gscons_info'
> is for the 'buf' member, so I still think no need to allocate it 2
> times.

It may be worth just reducing GS_BUFFER_SIZE slightly so that the gscons_info
structure itself is less than 8k.
If you can't get 2 adjacent pages then a lot of things will fail.

	David

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?