Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbbKRMO4 (ORCPT ); Wed, 18 Nov 2015 07:14:56 -0500 Received: from foss.arm.com ([217.140.101.70]:34285 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755237AbbKRMOy (ORCPT ); Wed, 18 Nov 2015 07:14:54 -0500 Date: Wed, 18 Nov 2015 12:14:50 +0000 From: Catalin Marinas To: Laura Abbott Cc: Will Deacon , Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro Message-ID: <20151118121450.GF27495@e104818-lin.cambridge.arm.com> References: <1447359670-23652-1-git-send-email-labbott@fedoraproject.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447359670-23652-1-git-send-email-labbott@fedoraproject.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 22 On Thu, Nov 12, 2015 at 12:21:10PM -0800, Laura Abbott wrote: > The permissions in mark_rodata_ro trigger a build error > with STRICT_MM_TYPECHECKS. Fix this by introducing > PAGE_KERNEL_ROX for the same reasons as PAGE_KERNEL_RO. > From Ard: > > "PAGE_KERNEL_EXEC has PTE_WRITE set as well, making the range > writeable under the ARMv8.1 DBM feature, that manages the > dirty bit in hardware (writing to a page with the PTE_RDONLY > and PTE_WRITE bits both set will clear the PTE_RDONLY bit in that case)" > > Signed-off-by: Laura Abbott Applied. Thanks. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/