Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933003AbbKRO3e (ORCPT ); Wed, 18 Nov 2015 09:29:34 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:55516 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932745AbbKRO3a (ORCPT ); Wed, 18 Nov 2015 09:29:30 -0500 X-Greylist: delayed 98750 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Nov 2015 09:29:28 EST From: Arnd Bergmann To: Peter Ujfalusi Cc: Vinod Koul , Geert Uytterhoeven , Tony Lindgren , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dan Williams , dmaengine@vger.kernel.org, "linux-serial@vger.kernel.org" , "linux-omap@vger.kernel.org" , Linux MMC List , linux-crypto@vger.kernel.org, linux-spi , Linux Media Mailing List , ALSA Development Mailing List Subject: Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Date: Wed, 18 Nov 2015 15:29:15 +0100 Message-ID: <6347063.Gd6coh6hX8@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <564C8966.9080406@ti.com> References: <1432646768-12532-1-git-send-email-peter.ujfalusi@ti.com> <20150624162401.GP19530@localhost> <564C8966.9080406@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:nMnXWC7zuCrnJgRLG5Pf2kLR5lsjdnnHD5HHE/2ZY8sdFVg0XCs A8FsF5sSOTiRT2nHVlM4rriY7kT00/i28C/S/0yBS639NXS7F5mRaPTw65VirJPgcRhAFwa E7npQsDLa5INZO02GPU0ZNQDFmCwq+O6Zj77s55D2SggJs7i6E6NW7RRmR7KvSo9sLYxLg6 QwhfvbXWaI7j+JYTpGUaw== X-UI-Out-Filterresults: notjunk:1;V01:K0:2BM6qgWQ2Mk=:R/gePYCPHZqJqiEKGBdww2 srKaiV2rp6ooYTplTNk7Ecp7AJgSSHr9SLhARnaKNWT4MzbViNKxWes5n5CmjwH407cgdCoHT lOmtYMcbBGFI/c+JqoWB/Rg9N5dKzIfRDWnp/fZp7aOokZwCCoS1AS+ESBEAXZw0m9j2pq17E qDS2ce/xCumVVOJbK/AZGw94CsHcaK8LeoDfJTNVcA780B6OJJWRf6Ow6p/LbQdzSMH2PbGDA dPUOorhyM115gBP2wO8pwzK/ls3rObxewPRGtBGhuMvaRR/kOTjAd8IRwNmUaRA2aUlRbBmWD okFJ1jVZBuSRVw1zel4Yi1NmFOOf3LAIlbMgS/BLWkiskop8mwq52H4pbIDYaMUhj0MPvs+in QmIdbqStmDjqALEGQd7Y+onpDbQ0sH7sLhh28Jl+Fz23JCGY+uJSd4pwJ+epGkyKmOghvi1rt LFD/9RBG9P6Wgk94Q+49XRcidxIlYI30ssRGM1kqBJpkNMBiew4lunzeKwmTxPheAzhETlUEQ pHo/FNZaIWKXsCO+CKkDsSniAFsGuOL3Ai/uOs6Yjx0C7eK08xjycSLRM7M42Hiz3WI6XH8rx ZAyLBPhlN/RnghTzmJNk/eZc/zF1IkFL4JMAPVdgl1jar8DxWYiCwZiwNAKlyG+9Eu57KWjnM QujbuWoq/yTr1GGZz5mxHA4kEXteXstE9ee4Q+vpp+U58UYsp1d5vJLtK0+WD/zVEGmaedYGr /lAnP2bmHjFNlE4w Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1169 Lines: 26 On Wednesday 18 November 2015 16:21:26 Peter Ujfalusi wrote: > 2. non slave channel requests, where only the functionality matters, like > memcpy, interleaved, memset, etc. > We could have a simple: > dma_request_channel(mask); > > But looking at the drivers using dmaengine legacy dma_request_channel() API: > Some sets DMA_INTERRUPT or DMA_PRIVATE or DMA_SG along with DMA_SLAVE: > drivers/misc/carma/carma-fpga.c DMA_INTERRUPT|DMA_SLAVE|DMA_SG > drivers/misc/carma/carma-fpga-program.c DMA_MEMCPY|DMA_SLAVE|DMA_SG > drivers/media/platform/soc_camera/mx3_camera.c DMA_SLAVE|DMA_PRIVATE > sound/soc/intel/common/sst-firmware.c DMA_SLAVE|DMA_MEMCPY > > as examples. > Not sure how valid are these... It's usually not much harder to separate out the legacy case from the normal dma_request_slave_channel_reason(), so those drivers don't really need to use the unified compat API. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/