Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756009AbbKROwh (ORCPT ); Wed, 18 Nov 2015 09:52:37 -0500 Received: from mga01.intel.com ([192.55.52.88]:34253 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755504AbbKROwe (ORCPT ); Wed, 18 Nov 2015 09:52:34 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,313,1444719600"; d="scan'208";a="841531116" Date: Wed, 18 Nov 2015 06:52:33 -0800 From: Jacob Pan To: Morten Rasmussen Cc: Peter Zijlstra , Ingo Molnar , Ingo Molnar , Thomas Gleixner , John Stultz , LKML , Arjan van de Ven , Srinivas Pandruvada , Len Brown , Rafael Wysocki , Eduardo Valentin , Paul Turner , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH 3/4] sched: introduce synchronized idle injection Message-ID: <20151118065233.1a883987@yairi> In-Reply-To: <20151118140440.GB30184@e105550-lin.cambridge.arm.com> References: <1447444387-23525-1-git-send-email-jacob.jun.pan@linux.intel.com> <1447444387-23525-4-git-send-email-jacob.jun.pan@linux.intel.com> <20151118083622.GA25217@gmail.com> <20151118103541.GE3816@twins.programming.kicks-ass.net> <20151118122702.GA30184@e105550-lin.cambridge.arm.com> <20151118124946.GF3816@twins.programming.kicks-ass.net> <20151118140440.GB30184@e105550-lin.cambridge.arm.com> Organization: OTC X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 24 On Wed, 18 Nov 2015 14:04:41 +0000 Morten Rasmussen wrote: > Then I'm confused :-/ > > I see the hrtimers, but the actual idle duration appears to be in > ticks rather than ms and then converted later. > > +/* Duration of idle time in ticks of each injection period > */ +unsigned int sysctl_sched_cfs_idle_inject_duration = 5UL; > > ...and futher down we have: > > + duration_msec = > jiffies_to_msecs(sysctl_sched_cfs_idle_inject_duration); I used hrtimers but still round around tick boundaries of ktime. It is more reliable than jiffies in terms of getting timely updates. Jacob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/