Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756287AbbKRQhN (ORCPT ); Wed, 18 Nov 2015 11:37:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:52766 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752184AbbKRQhL (ORCPT ); Wed, 18 Nov 2015 11:37:11 -0500 Date: Wed, 18 Nov 2015 17:37:07 +0100 From: Petr Mladek To: Chris J Arges Cc: live-patching@vger.kernel.org, jpoimboe@redhat.com, sjenning@redhat.com, jikos@kernel.org, vojtech@suse.com, jeyu@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc Message-ID: <20151118163707.GM4431@pathway.suse.cz> References: <1447431804-18786-1-git-send-email-chris.j.arges@canonical.com> <1447693391-10065-1-git-send-email-chris.j.arges@canonical.com> <1447693391-10065-3-git-send-email-chris.j.arges@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447693391-10065-3-git-send-email-chris.j.arges@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 24 On Mon 2015-11-16 11:03:06, Chris J Arges wrote: > In cases of duplicate symbols, sympos will be used to disambiguate instead > of val. By default sympos will be 0, and patching will only succeed if > the symbol is unique. Specifying a positive value will ensure that > occurrence of the symbol in kallsyms for the patched object will be used > for patching if it is valid. > > Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol > as they are no longer used. > > >From the klp_reloc structure remove val, as it can be refactored as a ^ Please, remove this extra '>'. I guess that you cut&pasted the comment from a mail reply ;-) Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/