Subject: Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to
 klp_reloc
To: Petr Mladek <pmladek@suse.com>
References: <1447431804-18786-1-git-send-email-chris.j.arges@canonical.com>
 <1447693391-10065-1-git-send-email-chris.j.arges@canonical.com>
 <1447693391-10065-3-git-send-email-chris.j.arges@canonical.com>
 <20151118163707.GM4431@pathway.suse.cz>
Cc: live-patching@vger.kernel.org, jpoimboe@redhat.com, sjenning@redhat.com,
        jikos@kernel.org, vojtech@suse.com, jeyu@redhat.com,
        linux-kernel@vger.kernel.org
From: Chris J Arges <chris.j.arges@canonical.com>
Message-ID: <564CA9BC.8020903@canonical.com>
Date: Wed, 18 Nov 2015 10:39:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151118163707.GM4431@pathway.suse.cz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 31

On 11/18/2015 10:37 AM, Petr Mladek wrote:
> On Mon 2015-11-16 11:03:06, Chris J Arges wrote:
>> In cases of duplicate symbols, sympos will be used to disambiguate instead
>> of val. By default sympos will be 0, and patching will only succeed if
>> the symbol is unique. Specifying a positive value will ensure that
>> occurrence of the symbol in kallsyms for the patched object will be used
>> for patching if it is valid.
>>
>> Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol
>> as they are no longer used.
>>
>> >From the klp_reloc structure remove val, as it can be refactored as a
>   ^
> Please, remove this extra '>'. I guess that you cut&pasted the
> comment from a mail reply ;-)
> 
> Best Regards,
> Petr
> 

I think that '>' was added in a subsequent reply. My patch doesn't have
that, and I'm guessing checkpatch would have warned me about that as well.
: )

--chris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/