Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756472AbbKRRM0 (ORCPT ); Wed, 18 Nov 2015 12:12:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:40585 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756187AbbKRRMX (ORCPT ); Wed, 18 Nov 2015 12:12:23 -0500 Date: Wed, 18 Nov 2015 09:12:21 -0800 From: Greg KH To: Jitendra Kumar Khasdev Cc: mchehab@osg.samsung.com, devel@driverdev.osuosl.org, Jitendra Kumar Khasdev , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c Message-ID: <20151118171221.GA13143@kroah.com> References: <1447862122-9820-1-git-send-email-jitendra.khasdev@hotwaxsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447862122-9820-1-git-send-email-jitendra.khasdev@hotwaxsystems.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 28 On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote: > This is a patch to the radio-bcm2048.c file that fixes up a brace warning > found by the checkpatch.pl tool. > > Signed-off-by: Jitendra Kumar Khasdev > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c > index b10d601..6226e02 100644 > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c > @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev, \ > } > > #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \ > -property_write(prop, signal size, mask, check) \ > -property_read(prop, size, mask) > +(property_write(prop, signal size, mask, check) \ > +property_read(prop, size, mask)) You didn't even test-build this patch, why not? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/