Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756615AbbKRSH7 (ORCPT ); Wed, 18 Nov 2015 13:07:59 -0500 Received: from lists.s-osg.org ([54.187.51.154]:33015 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778AbbKRSH6 (ORCPT ); Wed, 18 Nov 2015 13:07:58 -0500 Date: Wed, 18 Nov 2015 16:07:43 -0200 From: Mauro Carvalho Chehab To: Jitendra Cc: Greg KH , devel@driverdev.osuosl.org, Jitendra Kumar Khasdev , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c Message-ID: <20151118160743.581d50c2@recife.lan> In-Reply-To: <564CB6DF.5080700@gmail.com> References: <1447862122-9820-1-git-send-email-jitendra.khasdev@hotwaxsystems.com> <20151118171221.GA13143@kroah.com> <564CB6DF.5080700@gmail.com> Organization: Samsung X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1833 Lines: 45 Em Wed, 18 Nov 2015 23:05:27 +0530 Jitendra escreveu: > > > On Wednesday 18 November 2015 10:42 PM, Greg KH wrote: > > On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote: > >> This is a patch to the radio-bcm2048.c file that fixes up a brace warning > >> found by the checkpatch.pl tool. > >> > >> Signed-off-by: Jitendra Kumar Khasdev > >> --- > >> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c > >> index b10d601..6226e02 100644 > >> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c > >> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c > >> @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev, \ > >> } > >> > >> #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \ > >> -property_write(prop, signal size, mask, check) \ > >> -property_read(prop, size, mask) > >> +(property_write(prop, signal size, mask, check) \ > >> +property_read(prop, size, mask)) > > You didn't even test-build this patch, why not? > > > Greg KH, I have compiled the kernel by following these step: > 1. copied the .config files > 2. make defconfig > 3. make -j6 > It doesn't show me any warning. so I have tested on my side. defconfig won't compile all drivers. you need allyesconfig and/or allmodconfig. > -- > Thanks and Regards, > Jitendra Kumar Khasdev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/